ACK: [PATCH 3/4] dmicheck: skip checks of DMI default values for IFV

[ivanhu]

On 04/16/2018 01:06 PM, Alex Hung wrote:
> OEMs and ODMs are responsible to provide correct DMI data in their
> shipping products. Generating errors for DMI defaults are false
> positives from IFV's viewpoints.
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>   src/dmi/dmicheck/dmicheck.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 5965155..19ce16b 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1014,6 +1014,9 @@ static void dmi_str_check_index(fwts_framework *fw,
>   
>   		/* Scan for known BIOS defaults that vendors forget to set */
>   		for (j = 0; dmi_patterns[j].label != NULL; j++) {
> +			if (fw->flags & FWTS_FLAG_FIRMWARE_VENDOR)
> +				break;
> +
>   			if (dmi_patterns[j].field &&
>   				(strcmp(dmi_patterns[j].field, field) == 0) &&
>   				(strcmp(dmi_patterns[j].value, data) == 0)) {
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>