ACK: [PATCH 1/4] acpi: syntaxcheck: change it from batch to batch-experimental

Colin Ian King colin.king at canonical.com
Mon Apr 23 08:32:02 UTC 2018


On 16/04/18 06:06, Alex Hung wrote:
> The syntaxcheck is able to catch some asl errors in some cases, but it
> also generates too many false positives. The false positives often
> confuse first-time users and decrease fwts's usability. As a result,
> let's move it to batch-experimental until the number of false positives
> can be reduced.
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/syntaxcheck/syntaxcheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
> index eefafe0..1556b48 100644
> --- a/src/acpi/syntaxcheck/syntaxcheck.c
> +++ b/src/acpi/syntaxcheck/syntaxcheck.c
> @@ -645,6 +645,6 @@ static fwts_framework_ops syntaxcheck_ops = {
>  	.minor_tests = syntaxcheck_tests
>  };
>  
> -FWTS_REGISTER("syntaxcheck", &syntaxcheck_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH)
> +FWTS_REGISTER("syntaxcheck", &syntaxcheck_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH_EXPERIMENTAL)
>  
>  #endif
> 
Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list