ACK: [PATCH] dmi: dmicheck: fix missing spaces in failures of type 9

Colin Ian King colin.king at canonical.com
Mon Apr 23 08:31:11 UTC 2018


On 16/04/18 20:31, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 5965155d..6100e4c8 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1360,19 +1360,19 @@ static void dmicheck_entry(fwts_framework *fw,
>  			      ((data[0x5] >= 0xa0) && (data[0x5] <= 0xb6)))) {
>  				if (GET_UINT16(data + 0xd) != 0xffff)
>  					fwts_failed(fw, LOG_LEVEL_MEDIUM, DMI_VALUE_OUT_OF_RANGE,
> -						"Invalid value 0x%4.4" PRIx16 " was used and 0xffff"
> +						"Invalid value 0x%4.4" PRIx16 " was used and 0xffff "
>  						"should be used for non-PCI(e) while accessing entry '%s' @ "
>  						"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  						GET_UINT16(data + 0x0d), table, addr, "Segment Group Number", 0xd);
>  				if (data[0xf] != 0xff)
>  					fwts_failed(fw, LOG_LEVEL_MEDIUM, DMI_VALUE_OUT_OF_RANGE,
> -						"Invalid value 0x%2.2" PRIx8 " was used and 0xff"
> +						"Invalid value 0x%2.2" PRIx8 " was used and 0xff "
>  						"should be used for non-PCI(e) while accessing entry '%s' @ "
>  						"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  						data[0xf], table, addr, "Bus Number", 0xf);
>  				if (data[0x10] != 0xff)
>  					fwts_failed(fw, LOG_LEVEL_MEDIUM, DMI_VALUE_OUT_OF_RANGE,
> -						"Invalid value 0x%2.2" PRIx8 " was used and 0xff"
> +						"Invalid value 0x%2.2" PRIx8 " was used and 0xff "
>  						"should be used for non-PCI(e) while accessing entry '%s' @ "
>  						"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  						data[0x10], table, addr, "Device/Function Number", 0x10);
> 

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list