[PATCH] opal: cpu_info: Designate property optional

[Colin Ian King]

On 06/04/18 23:10, Deb McLemore wrote:
> Some properties do not apply per platform.
> 
> Signed-off-by: Deb McLemore <debmc at linux.vnet.ibm.com>
> ---
>  src/opal/cpu_info.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/src/opal/cpu_info.c b/src/opal/cpu_info.c
> index f923653..9dc084b 100644
> --- a/src/opal/cpu_info.c
> +++ b/src/opal/cpu_info.c
> @@ -88,19 +88,11 @@ static int get_xscom_property(fwts_framework *fw,
>  						my_path);
>  				}
>  			} else {
> -				failures ++;
>  				fwts_log_nl(fw);
> -				fwts_failed(fw,
> -					LOG_LEVEL_CRITICAL,
> -					"OPAL CPU Info",
> -					"Property of \"%s\" for \"%s\" was"
> -					" not able to be retrieved. Check the"
> -					" installation for the CPU device"
> -					" config for missing nodes in the"
> -					" device tree if you expect CPU"
> -					" devices.",
> -					property,
> -					my_path);
> +				fwts_skipped(fw, "OPAL CPU check for "
> +					"property of \"%s\" and path of \"%s\""
> +					" not applicable to version.",
> +					property, my_path);
>  			}
>  		} else {
>  			failures ++;
> 

"Some properties do not apply per platform".. so what happens to
platforms where these properties do apply - do no longer have a vaid
test because it's been skipped?

Colin