[PATCH] devicetree: dt_base: Make dtc warnings informational

[ppaidipe]

On 2018-04-07 03:45, Deborah McLemore wrote:
> It seems that calling out the dtc warnings as "warnings" alarms most
> consumers and since we advise no action necessary then the question is
> then why are they warnings ?
> 
> Valid concern, however to try to "quiet" them we thought this may be
> best.

I agree with alex here, a dtc warning should report as fwts warning, as 
we want the device tree
should be according to the spec standards. It will help developers to 
catch these warnings and
fix them in early stage.

Thanks
Pridhiviraj

> =====================================
> Deb McLemore
> IBM OpenPower - IBM Systems
> (512) 286 9980
> 
> debmc at us.ibm.com
> debmc at linux.vnet.ibm.com - (plain text)
> =====================================
> 
>> ----- Original message -----
>> From: Alex Hung <alex.hung at canonical.com>
>> Sent by: "fwts-devel" <fwts-devel-bounces at lists.ubuntu.com>
>> To: fwts-devel at lists.ubuntu.com
>> Cc:
>> Subject: Re: [PATCH] devicetree: dt_base: Make dtc warnings
>> informational
>> Date: Fri, Apr 6, 2018 3:43 PM
>> 
>> On 2018-04-06 01:19 PM, Deb McLemore wrote:
>>> Most dtc warnings are not issues so make the information
>>> available for review.
>>> 
>>> Signed-off-by: Deb McLemore <debmc at linux.vnet.ibm.com>
>>> ---
>>> src/devicetree/dt_base/dt_base.c | 9 ++++++---
>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/src/devicetree/dt_base/dt_base.c
>> b/src/devicetree/dt_base/dt_base.c
>>> index ead965f..666c1b0 100644
>>> --- a/src/devicetree/dt_base/dt_base.c
>>> +++ b/src/devicetree/dt_base/dt_base.c
>>> @@ -109,10 +109,13 @@ static int
>> dt_base_check_warnings(fwts_framework *fw)
>>> }
>>> 
>>> if (out_len > 0) {
>>> - fwts_failed(fw, LOG_LEVEL_MEDIUM,
>>> - "DeviceTreeBaseDTCWarnings",
>>> - "dtc reports warnings from device tree:%s",
>>> + fwts_passed(fw, "Some warnings from dtc. "
>>> + "Run comand "dtc -I fs -O dts -o my.dts "
>>> + "/sys/firmware/devicetree/base" for "
>>> + "further review");
>> 
>> Putting a warning messages as parts of pass is somehow awkward. Will
>> fwts_warning(fw, "Some warning ...) be more suitable here?
>> 
>>> + fwts_advice(fw, "Review dtc findings: %s",
>>> output);
>>> + ret = FWTS_OK;
>>> goto err;
>>> }
>>> 
>>> 
>> 
>> --
>> Cheers,
>> Alex Hung
>> 
>> --
>> fwts-devel mailing list
>> fwts-devel at lists.ubuntu.com
>> Modify settings or unsubscribe at:
>> 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=
>> [1]
> 
> 
> 
> Links:
> ------
> [1]
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ubuntu.com_mailman_listinfo_fwts-2Ddevel&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=V3KRDPsp3yMosW9R4elWYg&m=HDEEqh-nQRIzTXZ1JPaziP17ARgzZyvyvKBhSrCkVH0&s=soGqrb_vb61U9OExM-s4pgRtIKh5hzgHl-ds4n_lkyI&e=