[PATCH] devicetree: dt_base: Make dtc warnings informational

[Alex Hung]

On 2018-04-06 01:19 PM, Deb McLemore wrote:
> Most dtc warnings are not issues so make the information
> available for review.
> 
> Signed-off-by: Deb McLemore <debmc at linux.vnet.ibm.com>
> ---
>   src/devicetree/dt_base/dt_base.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/devicetree/dt_base/dt_base.c b/src/devicetree/dt_base/dt_base.c
> index ead965f..666c1b0 100644
> --- a/src/devicetree/dt_base/dt_base.c
> +++ b/src/devicetree/dt_base/dt_base.c
> @@ -109,10 +109,13 @@ static int dt_base_check_warnings(fwts_framework *fw)
>   	}
>   
>   	if (out_len > 0) {
> -		fwts_failed(fw, LOG_LEVEL_MEDIUM,
> -			"DeviceTreeBaseDTCWarnings",
> -			"dtc reports warnings from device tree:%s",
> +		fwts_passed(fw, "Some warnings from dtc. "
> +			"Run comand \"dtc -I fs -O dts -o my.dts "
> +			"/sys/firmware/devicetree/base\" for "
> +			"further review");

Putting a warning messages as parts of pass is somehow awkward. Will 
fwts_warning(fw, "Some warning ...)  be more suitable here?


> +		fwts_advice(fw, "Review dtc findings: %s",
>   			output);
> +		ret = FWTS_OK;
>   		goto err;
>   	}
>   
> 


-- 
Cheers,
Alex Hung