FWTS Compliance test suit: FACS Firmware ACPI Control Structure test issue

[Alex Hung]

Hi Rameshwar,

Thanks for providing information and a patch for fwts.

Could you please submit the patch, with signed-off-by, by git, ex. git
send-email --to fwts-devel at lists.ubuntu.com facs.patch? You may want
to have the analysis as part of patch descriptions. It is easier for
maintainers to applying and keeping tracks of new patches.

Please let me know if you still have questions about submitting patches to fwts.

Cheers,
Alex Hung

On Fri, Apr 6, 2018 at 1:00 AM, Rameshwar Sahu <rsahu at apm.com> wrote:
> Hi All,
>
> This is Rameshwar Prasad Sahu from company called "Ampere Computing".
> I am currently running FWTS compliance test suit on our ARM64 arch
> based development boards.
>
> I came across below test cases failure:
> facs: FACS Firmware ACPI Control Structure test.
> --------------------------------------------------------------------------------
> Test 1 of 1: FACS Firmware ACPI Control Structure test.
> FACS Firmware ACPI Control Structure:
>   Signature:                'FACS'
>   Length:                   0x00000040
>   Hardware Signature:       0x00000000
>   Firmware Waking Vector:   0x00000000
>   Global Lock:              0x00000000
>   Flags:                    0x00000000
>   X-Firmware Waking Vector: 0x0000000000000000
>   Version:                  0x02
>   Reserved:                 0x00 0x00 0x00
>   OSPM Flags:               0x00000000
>   Reserved:                 0x00 0x00 0x00 0x00
>   Reserved:                 0x00 0x00 0x00 0x00
>   Reserved:                 0x00 0x00 0x00 0x00
>   Reserved:                 0x00 0x00 0x00 0x00
>   Reserved:                 0x00 0x00 0x00 0x00
>   Reserved:                 0x00 0x00 0x00 0x00
> FAILED [MEDIUM] FACSNotReserved: Test 1, FACS: The FACS does not seem to be
> in a
> reserved memory region, check that the BIOS memory map is correctly
> reserving
> the address space 0xbfffd40040-0xbfffd40080
>
> ================================================================================
> 0 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0 info only.
> ================================================================================
>
>
> While debugging this test case failure issue I found that our BIOS
> code is fine with memory allocation for FACS structure from the
> expected reserved memory zone and there is compliance test suit coding
> issue, which explained as below:
>
> I am using Linux 4.11.0 kernel to run this test suit, so basically
> here is the FWTS coding flow for FACS structure memory check test:
>
> 1. First FWTS try to gather the BIOS memory map list info from the sysfs
> files
> called "/sys/firmware/memmap" which currently doesn't exists for the ARM
> arch.
> Currently it exists only for x86 arch by the driver module called
> "/linux/arch/x86/kernel/e820.c", so in our case we fail here.
>
> 2. If it fails in #1 (e.g. in our case it failed) then it try to get BIOS
> memory map list info from the klog(kernel log) by searching string
> "BIOS-memory_map" in klog and add BIOS memory map  info in the list if
> found this in klog but we fail here also because "BIOS-memory_map"
> string doesn't exists in klog for 4.11 kernel,so we BIOS memory map
> info list is empty.
>
> 3. As per my understanding/debugging, the FWTS compliance test suit
> code does't take care of #2 failure, I mean it assumes that we got
> BIOS memory map list from the klog always even though there is no such
> string "BIOS-memory_map" in klog. So before checking FACS structure
> address is reserved or not by comparing range in BIOS memory map list,
> it should check whether list is empty or not.
>
> Here I attached my patch work to fix above issue, correct me if I am wrong
> here.
>
> Also could you people please guide me with you kind suggestions here.
>
> Thanks,
> Ram
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/fwts-devel
>



-- 
Cheers,
Alex Hung