fixing ACPI wakealarm test?

Colin Ian King colin.king at canonical.com
Tue Sep 26 23:33:32 UTC 2017


On 27/09/17 00:27, Al Stone wrote:
> So, some platforms don't really have an ACPI wake alarm, but the test is set to
> essentially always be run:
> 
> FWTS_REGISTER("wakealarm", &wakealarm_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH |
> FWTS_FLAG_ROOT_PRIV)
> 
> Is there a recommended way to make a test more hardware specific?  Granted, if
> I run FWTS on the platform, I can double check and make sure /sys/class/rtc/rtc0
> exists (or something like that); if I run FWTS elsewhere, though, that's clearly
> not going to work.  I know I've added options in the past for architectures, but
> this is specific to an individual machine and it would seem like overkill to
> put in options for specific machines.
> 
> Suggestions?

Perhaps the simplest approach is to skip all the subsequent tests if
wakealarm_test1() fails to find a working interface.

> 
> BTW, I was not able to file a bug for this without registering with Ubuntu One;
> is that really necessary?
> 
Afraid so :-(

Colin




More information about the fwts-devel mailing list