[PATCH V2 2/2] dmi: dmicheck: Add BMC Interface Type definitions from IPMI spec

Jeffrey Hugo jhugo at codeaurora.org
Fri Sep 15 19:25:45 UTC 2017


The Intelligent Platform Management Interface (IPMI) Specification defines
BMC Interface Types in section C1-1.1.  Type 4 is an addition in the IPMI
spec which does not appear in the SMBIOS spec, which means "SSIF: SMBus
System Interface".

Add type 4 as a valid type to the test.

Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
---
 src/dmi/dmicheck/dmicheck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index 2e139ad..236edc6 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1768,7 +1768,7 @@ static void dmicheck_entry(fwts_framework *fw,
 
 		case 38: /* 7.39 */
 			table = "IPMI Device Information (Type 38)";
-			dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x3);
+			dmi_min_max_uint8_check(fw, table, addr, "Interface Type", hdr, 0x4, 0x0, 0x4);
 
 			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2);
 			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.




More information about the fwts-devel mailing list