ACK: [PATCH 1/2] dmi: dmicheck: Add BMC Interface Type definitions from SMBIOS spec

[Colin Ian King]

On 11/09/17 22:36, Jeffrey Hugo wrote:
> The SMBIOS spec defines BMC Interface Types in section 7.39.1.  Value 0 is
> defined as "Unknown" (might be a platform specific interface), and value 3
> is "BT: Block Transfer".  Update the test to accept these definitions.
> 
> Fixes: 00445adbcb5a ("dmi: dmicheck: add SBBR compliance tests")
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 61c6b81..c0e78f0 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1772,7 +1772,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  
>  			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2);
>  			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
> -			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x1, 0x2, 6, 0x3);
> +			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x3, 6, 0x3);
>  			break;
>  
>  		case 39: /* 7.40 */
> 
Acked-by: Colin Ian King <colin.king at canonical.com>