ACK: [PATCH] lib: constify a couple of arrays
Alex Hung
alex.hung at canonical.com
Tue Sep 5 05:29:19 UTC 2017
On 2017-09-04 05:09 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Since these arrays are read-only and static we can also constify them too.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> src/lib/src/fwts_log.c | 2 +-
> src/lib/src/fwts_uefi.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c
> index 13d5f6ca..1660ae2a 100644
> --- a/src/lib/src/fwts_log.c
> +++ b/src/lib/src/fwts_log.c
> @@ -221,7 +221,7 @@ fwts_log_field fwts_log_str_to_field(const char *text)
> {
> int i;
>
> - static struct mapping {
> + static const struct mapping {
> char *text;
> fwts_log_field field;
> } mappings[] = {
> diff --git a/src/lib/src/fwts_uefi.c b/src/lib/src/fwts_uefi.c
> index 1f9d31fa..263bd657 100644
> --- a/src/lib/src/fwts_uefi.c
> +++ b/src/lib/src/fwts_uefi.c
> @@ -425,7 +425,7 @@ int fwts_uefi_get_variable_names(fwts_list *list)
> return ret;
> }
>
> -static uefistatus_info uefistatus_info_table[] = {
> +static const uefistatus_info uefistatus_info_table[] = {
> { EFI_SUCCESS, "EFI_SUCCESS", "The operation completed successfully." },
> { EFI_LOAD_ERROR, "EFI_LOAD_ERROR", "The image failed to load." },
> { EFI_INVALID_PARAMETER, "EFI_INVALID_PARAMETER", "A parameter was incorrect." },
> @@ -466,7 +466,7 @@ static uefistatus_info uefistatus_info_table[] = {
> void fwts_uefi_print_status_info(fwts_framework *fw, const uint64_t status)
> {
>
> - uefistatus_info *info;
> + const uefistatus_info *info;
>
> for (info = uefistatus_info_table; info->mnemonic != NULL; info++) {
> if (status == info->statusvalue) {
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list