ACK: [PATCH 2/4] acpi: devices: add new tests for ambient light sensor device
Colin Ian King
colin.king at canonical.com
Fri Oct 20 16:36:41 UTC 2017
On 17/10/17 08:36, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
> src/Makefile.am | 1 +
> src/acpi/devices/sensor/als.c | 193 ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 194 insertions(+)
> create mode 100644 src/acpi/devices/sensor/als.c
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index fe8bc02..490809f 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -52,6 +52,7 @@ fwts_SOURCES = main.c \
> acpi/devices/buttons/power_button.c \
> acpi/devices/buttons/sleep_button.c \
> acpi/devices/lid/lid.c \
> + acpi/devices/sensor/als.c \
> acpi/acpidump/acpidump.c \
> acpi/acpiinfo/acpiinfo.c \
> acpi/acpitables/acpitables.c \
> diff --git a/src/acpi/devices/sensor/als.c b/src/acpi/devices/sensor/als.c
> new file mode 100644
> index 0000000..fed9a3f
> --- /dev/null
> +++ b/src/acpi/devices/sensor/als.c
> @@ -0,0 +1,193 @@
> +/*
> + * Copyright (C) 2017 Canonical
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> + *
> + */
> +#include "fwts.h"
> +
> +#if defined(FWTS_HAS_ACPI)
> +
> +#include "fwts_acpi_object_eval.h"
> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <unistd.h>
> +#include <inttypes.h>
> +#include <string.h>
> +
> +#define FWTS_ACPI_AMBIENT_LIGHT_HID "ACPI0008"
> +
> +static ACPI_HANDLE device;
> +
> +static ACPI_STATUS get_device_handle(ACPI_HANDLE handle, uint32_t level,
> + void *context, void **ret_val)
> +{
> + FWTS_UNUSED(level);
> + FWTS_UNUSED(context);
> + FWTS_UNUSED(ret_val);
> +
> + device = handle;
> + return AE_CTRL_TERMINATE;
> +}
> +
> +static int ambient_light_init(fwts_framework *fw)
> +{
> + ACPI_STATUS status;
> +
> + if (fwts_acpica_init(fw) != FWTS_OK)
> + return FWTS_ERROR;
> +
> + status = AcpiGetDevices(FWTS_ACPI_AMBIENT_LIGHT_HID, get_device_handle, NULL, NULL);
> + if (ACPI_FAILURE(status)) {
> + fwts_log_error(fw, "Cannot find the ACPI device");
> + return FWTS_ERROR;
> + }
> +
> + if (!device) {
> + fwts_log_error(fw, "ACPI ambient light sensor device does not exist, skipping test");
> + fwts_acpica_deinit();
> + return FWTS_SKIP;
> + } else {
> + ACPI_BUFFER buffer;
> + char full_name[128];
> +
> + buffer.Length = sizeof(full_name);
> + buffer.Pointer = full_name;
> +
> + status = AcpiGetName(device, ACPI_FULL_PATHNAME, &buffer);
> + if (ACPI_SUCCESS(status)) {
> + fwts_log_info_verbatim(fw, "ACPI Ambient Light Sensor Device: %s", full_name);
> + fwts_log_nl(fw);
> + }
> + }
> +
> + return FWTS_OK;
> +}
> +
> +static int method_test_ALI(fwts_framework *fw)
> +{
> + return fwts_evaluate_method(fw, METHOD_MANDATORY, &device,
> + "_ALI", NULL, 0, fwts_method_test_integer_return, NULL);
> +}
> +
> +static int method_test_ALC(fwts_framework *fw)
> +{
> + return fwts_evaluate_method(fw, METHOD_OPTIONAL, &device,
> + "_ALC", NULL, 0, fwts_method_test_integer_return, NULL);
> +}
> +
> +static int method_test_ALT(fwts_framework *fw)
> +{
> + return fwts_evaluate_method(fw, METHOD_OPTIONAL, &device,
> + "_ALT", NULL, 0, fwts_method_test_integer_return, NULL);
> +}
> +
> +static void method_test_ALR_return(
> + fwts_framework *fw,
> + char *name,
> + ACPI_BUFFER *buf,
> + ACPI_OBJECT *obj,
> + void *private)
> +{
> + uint32_t i;
> + bool failed = false;
> + uint32_t adjustment = 0, illuminance = 0;
> +
> + FWTS_UNUSED(private);
> +
> + if (fwts_method_check_type(fw, name, buf, ACPI_TYPE_PACKAGE) != FWTS_OK)
> + return;
> +
> + /* Could be one or more sub-packages */
> + for (i = 0; i < obj->Package.Count; i++) {
> + ACPI_OBJECT *pkg;
> +
> + pkg = &obj->Package.Elements[i];
> + if (pkg->Package.Count != 2) {
> + fwts_failed(fw, LOG_LEVEL_MEDIUM,
> + "Method_ALRBadSubPackageElementCount",
> + "%s sub-package %" PRIu32 " was expected to "
> + "have 2 elements, got %" PRIu32 " elements instead.",
> + name, i, pkg->Package.Count);
> + failed = true;
> + } else {
> + /* elements should be listed in monotonically increasing order */
> + if (pkg->Package.Elements[0].Type != ACPI_TYPE_INTEGER ||
> + adjustment > pkg->Package.Elements[0].Integer.Value) {
> + fwts_failed(fw, LOG_LEVEL_MEDIUM,
> + "Method_ALRBadSubPackageReturnType",
> + "%s sub-package %" PRIu32
> + " element 0 is an invalid integer.",
> + name, i);
> + failed = true;
> + }
> +
> + if (pkg->Package.Elements[1].Type != ACPI_TYPE_INTEGER ||
> + illuminance > pkg->Package.Elements[1].Integer.Value) {
> + fwts_failed(fw, LOG_LEVEL_MEDIUM,
> + "Method_ALRBadSubPackageReturnType",
> + "%s sub-package %" PRIu32
> + " element 1 is an invalid integer.",
> + name, i);
> + failed = true;
> + }
> + adjustment = pkg->Package.Elements[0].Integer.Value;
> + illuminance = pkg->Package.Elements[1].Integer.Value;
> + }
> + }
> +
> + if (!failed)
> + fwts_method_passed_sane(fw, name, "package");
> +}
> +
> +static int method_test_ALR(fwts_framework *fw)
> +{
> + return fwts_evaluate_method(fw, METHOD_MANDATORY, &device,
> + "_ALR", NULL, 0, method_test_ALR_return, NULL);
> +}
> +
> +static int method_test_ALP(fwts_framework *fw)
> +{
> + return fwts_evaluate_method(fw, METHOD_OPTIONAL, &device,
> + "_ALP", NULL, 0, fwts_method_test_polling_return, "_ALP");
> +}
> +
> +static fwts_framework_minor_test ambient_light_tests[] = {
> + { method_test_ALI, "Test _ALI (Ambient Light Illuminance)." },
> + { method_test_ALC, "Test _ALC (Ambient Light Colour Chromaticity)." },
> + { method_test_ALT, "Test _ALT (Ambient Light Temperature)." },
> + { method_test_ALR, "Test _ALR (Ambient Light Response)."},
> + { method_test_ALP, "Test _ALP (Ambient Light Polling)."},
> + { NULL, NULL }
> +};
> +
> +static int ambient_light_deinit(fwts_framework *fw)
> +{
> + FWTS_UNUSED(fw);
> + fwts_acpica_deinit();
> +
> + return FWTS_OK;
> +}
> +
> +static fwts_framework_ops ambient_light_ops = {
> + .description = "Ambient light sensor device test",
> + .init = ambient_light_init,
> + .deinit = ambient_light_deinit,
> + .minor_tests = ambient_light_tests
> +};
> +
> +FWTS_REGISTER("acpi_als", &ambient_light_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> +
> +#endif
>
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the fwts-devel
mailing list