FWTS tip does not compile

Alex Hung alex.hung at canonical.com
Mon May 15 17:59:39 UTC 2017


Hi Jeffrey,

Please try to install libfdt-dev and configure again:

ex. Ubuntu
sudo apt install libfdt-dev
autoreconf -ivf && ./configure
make clean && make -j4


On Mon, May 15, 2017 at 10:21 AM, Jeffrey Hugo <jhugo at codeaurora.org> wrote:
> FWTS tip does not compile for me (see errors below).  If I revert both
> "fwts/opal: Power management DT Validation tests." and "fwts/opal: Reserved
> memory DT validation tests.", it compiles again.  I think reverting only the
> first one is necessary, but one would need to handle the merge conflict.
>
> Is more info needed to address this?
>
> Log snippet:
>
> gcc -DHAVE_CONFIG_H -I. -I..  -I../src/lib/include
> -I../src/acpica/source/include -I../src/acpica/source/compiler
> -I../efi_runtime `pkg-config --silence-errors --cflags json` `pkg-config
> --silence-errors --cflags json-c` -pthread `pkg-config --cflags glib-2.0
> gio-2.0` -Wall -Werror -Wextra -DACPI_DEBUG_OUTPUT   -g -O2 -MT
> opal/fwts-power_mgmt_info.o -MD -MP -MF opal/.deps/fwts-power_mgmt_info.Tpo
> -c -o opal/fwts-power_mgmt_info.o `test -f 'opal/power_mgmt_info.c' || echo
> './'`opal/power_mgmt_info.c
> opal/power_mgmt_info.c: In function ‘pstate_limits_test’:
> opal/power_mgmt_info.c:132:11: error: implicit declaration of function
> ‘fdt_path_offset’ [-Werror=implicit-function-declaration]
>   offset = fdt_path_offset(fw->fdt, power_mgt_path);
>            ^
> In file included from ../src/lib/include/fwts_binpaths.h:27:0,
>                  from ../src/lib/include/fwts.h:54,
>                  from opal/power_mgmt_info.c:25:
> opal/power_mgmt_info.c:144:4: error: implicit declaration of function
> ‘fdt_strerror’ [-Werror=implicit-function-declaration]
>     fdt_strerror(pstate_min));
>     ^
> ../src/lib/include/fwts_framework.h:235:84: note: in definition of macro
> ‘fwts_failed’
>  mework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> args)
>
>    ^
> opal/power_mgmt_info.c:143:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 7 has type ‘int’ [-Werror=format=]
>     "Failed to read property ibm,pstate-min %s",
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c:152:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 7 has type ‘int’ [-Werror=format=]
>     "Failed to read property ibm,pstate-max %s",
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c:161:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 7 has type ‘int’ [-Werror=format=]
>     "Failed to read property ibm,pstate-ids %s",
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c: In function ‘cpuidle_states_test’:
> opal/power_mgmt_info.c:286:9: error: implicit declaration of function
> ‘fdt_getprop’ [-Werror=implicit-function-declaration]
>    buf = fdt_getprop(fw->fdt, offset, "ibm,enabled-stop-levels",
>          ^
> opal/power_mgmt_info.c:286:7: error: assignment makes pointer from integer
> without a cast [-Werror=int-conversion]
>    buf = fdt_getprop(fw->fdt, offset, "ibm,enabled-stop-levels",
>        ^
> In file included from ../src/lib/include/fwts_binpaths.h:27:0,
>                  from ../src/lib/include/fwts.h:54,
>                  from opal/power_mgmt_info.c:25:
> opal/power_mgmt_info.c:301:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 7 has type ‘int’ [-Werror=format=]
>     "Failed to read property ibm,cpu-idle-state-flags %s",
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c:324:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 7 has type ‘int’ [-Werror=format=]
>     "Failed to read property"
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c:349:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 7 has type ‘int’ [-Werror=format=]
>     "Failed to read property "
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c:364:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 8 has type ‘int’ [-Werror=format=]
>     "Failed to read property %s rc: %s", control_prop,
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c:377:4: error: format ‘%s’ expects argument of type
> ‘char *’, but argument 8 has type ‘int’ [-Werror=format=]
>     "Failed to read property %s rc: %s", mask_prop,
>     ^
> ../src/lib/include/fwts_framework.h:235:76: note: in definition of macro
> ‘fwts_failed’
>  ramework_log(fw, LOG_FAILED, label, level, &fw->minor_tests.failed, fmt, ##
> arg
>                                                                      ^
> opal/power_mgmt_info.c: In function ‘pstate_limits_test’:
> opal/power_mgmt_info.c:166:30: error: ‘pstate_max’ may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
>   nr_pstates = abs(pstate_max - pstate_min) + 1;
>                               ^
> opal/power_mgmt_info.c:166:30: error: ‘pstate_min’ may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
> opal/power_mgmt_info.c:188:5: error: ‘len’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
>   if (len != nr_pstates)
>      ^
> opal/power_mgmt_info.c: In function ‘cpuidle_states_test’:
> opal/power_mgmt_info.c:75:5: error: ‘test_len’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
>   if (prop1_len == prop2_len)
>      ^
> opal/power_mgmt_info.c:248:19: note: ‘test_len’ was declared here
>   int offset, len, test_len, ret;
>                    ^
> cc1: all warnings being treated as errors
> Makefile:3523: recipe for target 'opal/fwts-power_mgmt_info.o' failed
> make[3]: *** [opal/fwts-power_mgmt_info.o] Error 1
> make[3]: Leaving directory '/home/ubuntu/fwts/src'
> Makefile:3872: recipe for target 'all-recursive' failed
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory '/home/ubuntu/fwts/src'
> Makefile:760: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/home/ubuntu/fwts'
> Makefile:691: recipe for target 'all' failed
> make: *** [all] Error 2
>
> --
> Jeffrey Hugo
> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies,
> Inc.
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/fwts-devel



-- 
Cheers,
Alex Hung



More information about the fwts-devel mailing list