[PATCH] dmi: dmicheck: fix a typo in a type 15's error message
Alex Hung
alex.hung at canonical.com
Fri May 5 23:21:17 UTC 2017
Oops, it was used for other testing. I will fix it in V2
On Fri, May 5, 2017 at 2:51 PM, Colin Ian King <colin.king at canonical.com> wrote:
> On 05/05/17 20:51, Alex Hung wrote:
>> Signed-off-by: Alex Hung <alex.hung at canonical.com>
>> ---
>> src/dmi/dmicheck/dmicheck.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
>> index 77bfda6..94db496 100644
>> --- a/src/dmi/dmicheck/dmicheck.c
>> +++ b/src/dmi/dmicheck/dmicheck.c
>> @@ -1256,6 +1256,8 @@ static void dmicheck_entry(fwts_framework *fw,
>> table = "BIOS Language Information (Type 13)";
>> if (hdr->length < 0x16)
>> break;
>> +
>> + fwts_log_info(fw, "Lang flag = %x", data[5]);
>
> Is the above info message intentional?
>
>> for (i = 1; i <= hdr->data[4]; i++) {
>> snprintf(tmp, sizeof(tmp), "BIOS Language String %d", i);
>> dmi_str_check_index(fw, table, addr, tmp, hdr, 0x4, i);
>> @@ -1278,7 +1280,7 @@ static void dmicheck_entry(fwts_framework *fw,
>> if (!((val <= 0x04) || (val >= 0x80))) {
>> fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>> "Out of range value 0x%2.2" PRIx8 " "
>> - "(range allowed 0x00..0x01, "
>> + "(range allowed 0x00..0x04, "
>> "0x80..0xff) while accessing entry '%s' @ "
>> "0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>> val, table, addr, "Access Method", 0x0a);
>>
>
--
Cheers,
Alex Hung
More information about the fwts-devel
mailing list