ACK: [PATCH 1/3] acpi: method: update _GCP according to ACPI 6.2 (mantis 1703)

ivanhu ivan.hu at canonical.com
Thu Jun 22 07:16:12 UTC 2017


On 06/22/2017 10:32 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>   src/acpi/method/method.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index bcc2f63..a99c7d0 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -4698,11 +4698,11 @@ static void method_test_GCP_return(
>   	if (method_check_type(fw, name, buf, ACPI_TYPE_INTEGER) != FWTS_OK)
>   		return;
>   
> -	if (obj->Integer.Value & ~0x1f)
> +	if (obj->Integer.Value & ~0x1ff)
>   		fwts_failed(fw, LOG_LEVEL_MEDIUM,
>   			"Method_GCPReturn",
> -			"%s returned %" PRId64 ", should be between 0 and 31, "
> -			"one or more of the reserved bits 5..31 seem "
> +			"%s returned %" PRId64 ", should be between 0 and 0x1ff, "
> +			"one or more of the reserved bits 9..31 seem "
>   			"to be set.",
>   			name, (uint64_t)obj->Integer.Value);
>   	else
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list