ACK: [PATCH] klog.json: Add EINJ driver errors to the klog database

[ivanhu]

On 2017年01月17日 23:09, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> This covers most of the useful error/warnings from the current driver.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  data/klog.json | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index e487a18..75df4d9 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3,6 +3,76 @@
>   [
>    {
>     "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Firmware does not respond in time",
> +   "advice": "The ACPI Error Injection (EINJ) driver attempted to inject an error however the firmware took longer than expected to respond and a time-out occurred.",
> +   "label": "KlogAcpiEinjFirmwareTimeout",
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Can not request .* for Trigger table",
> +   "advice": "The ACPI Error Injection (EINJ) driver attempted to request a memory region for the APEI EINJ trigger table but the request failed, perhaps the mapping was incorrect.",
> +   "label": "KlogAcpiEinjFailedMemRegion",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Failed to map trigger table",
> +   "advice": "The ACPI Error Injection (EINJ) driver attempted to IO remap the APEI EINJ trigger table, but the mapping failed.",
> +   "label": "KlogAcpiEinjFailedIoremap",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "EINJ table not found",
> +   "advice": "The ACPI Error Injection (EINJ) driver could not find an ACPI EINJ table, EINJ functionality is disabled.",
> +   "label": "KlogAcpiEinjNotFound",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Failed to get EINJ table",
> +   "advice": "The ACPI Error Injection (EINJ) driver could not get an ACPI EINJ table, EINJ functionality is disabled.",
> +   "label": "KlogAcpiEinjGetFailed",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Invalid EINJ table",
> +   "advice": "The ACPI Error Injection Table (EINJ) was invalid, possible because of an incorrect header length or an incorrect table size for the number of entries in the table.",
> +   "label": "KlogAcpiEinjInvalid",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Error collecting EINJ resources",
> +   "advice": "The ACPI Error Injection (EINJ) driver detected either an invalid Generic Address Structure (GAR) in an injection instruction entry, or resource space ID was not system memeory or system I/O.",
> +   "label": "KlogAcpiEinjResourcesFailure",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Error requesting memory/port resources",
> +   "advice": "The ACPI Error Injection (EINJ) driver failed to request system meory or system I/O port resources, EINJ functionality is disabled.",
> +   "label": "KlogAcpiEinjResourcesFailure",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Error pre-mapping GARs",
> +   "advice": "The ACPI Error Injection (EINJ) driver failed to map the address spaces specified by the injection instuction entry Generic Address Structures (GAR), EINJ functionality is disabled.",
> +   "label": "KlogAcpiEinjGarMapFailed",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Error creating param extension debugfs nodes",
> +   "advice": "The ACPI Error Injection (EINJ) driver failed to create debugfs nodes.",
> +   "label": "KlogAcpiEinjDebugfsFailed",
> +  },
> +  {
> +   "compare_mode": "string",
>     "log_level": "LOG_LEVEL_MEDIUM",
>     "pattern": "Failed to initialize debugger",
>     "advice": "An error occurred when initializing the ACPI AML debugger so the debugger cannot be started.",
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>