[PATCH 1/2 v2] fedora/fwts.spec: Add initial version of fwts.spec

[Colin Ian King]

On 13/01/17 18:15, Prarit Bhargava wrote:
> On 01/13/2017 11:54 AM, Colin Ian King wrote:
>> On 13/01/17 16:42, Prarit Bhargava wrote:
>>> This is the first version of the Fedora/Red Hat rpm spec.
>>>
>>> The resulting binary rpm contains
>>>
>>> [root at intel-brickland-07 fedora]# rpm -qpl /root/rpmbuild/RPMS/x86_64/fwts-16-01.00.el7.x86_64.rpm
>>> /lib64/libfwts.so.1
>>> /lib64/libfwts.so.1.0.0
>>> /lib64/libfwtsacpica.so
>>> /lib64/libfwtsacpica.so.1
>>> /lib64/libfwtsacpica.so.1.0.0
>>> /lib64/libfwtsiasl.so
>>> /lib64/libfwtsiasl.so.1
>>> /lib64/libfwtsiasl.so.1.0.0
>>> /usr/bin/fwts
>>> /usr/bin/fwts-collect
>>> /usr/bin/fwts-frontend-text
>>> /usr/local/share/fwts/syntaxcheck.json
>>> /usr/share/fwts
>>> /usr/share/fwts/fwts-live-dialogrc
>>> /usr/share/fwts/klog.json
>>> /usr/share/man/man1/fwts-collect.1.gz
>>> /usr/share/man/man1/fwts-frontend-text.1.gz
>>> /usr/share/man/man1/fwts.1.gz
>>>
>>> [v2]: Update license to GPLv2, LGPL.
>>> [v3]: Add bison and flex to BuildRequires
>>>
>>> Signed-off-by: Prarit Bhargava <prarit at redhat.com>
>>> ---
>>>  fedora/fwts.spec |   81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 81 insertions(+)
>>>  create mode 100644 fedora/fwts.spec
>>>
>>> diff --git a/fedora/fwts.spec b/fedora/fwts.spec
>>> new file mode 100644
>>> index 000000000000..360a52b4cb00
>>> --- /dev/null
>>> +++ b/fedora/fwts.spec
>>> @@ -0,0 +1,81 @@
>>> +# Only these 3 values need to change for package version control
>>> +%global major 16
>>> +%global minor 01
>>> +%global subminor 00
>>
>> I had some build issues with gcc 6.3.1 20161221 mainly because I needed
>> the following fix:
>>
>> commit dfaf060696fc8f8873b171f5b80c4e968a3833bc
>> Author: Colin Ian King <colin.king at canonical.com>
>> Date:   Wed Jan 13 16:03:33 2016 +0000
>>
>>     lib: fwts_klog: fix incorrect indentation, detected by gcc-6
>>
>>     Signed-off-by: Colin Ian King <colin.king at canonical.com>
>>     Acked-by: Alex Hung <alex.hung at canonical.com>
>>     Acked-by: Ivan Hu <ivan.hu at canonical.com>
>>
>> ..so I bumped the minor version to 12 (which is the latest version) and
>> it builds the RPM \o/.  I installed it and it works fine.
>>
> 
> Woot! :)
> 
>> So.. I'm happy with this, apart from:
>>
>> 1. should that minor version be more current (e.g. 12)
> 
> I looked at https://wiki.ubuntu.com/FirmwareTestSuite which lists V16.01.00 ?  I
> did note that the git tree had a higher version but went with the publicly
> documented value.  I assumed that was a stable value.

Apologies for that, we've not updated that wiki for a while. fwts is
generally released every month except for April and October. The best
bet is to look for the latest release in http://fwts.ubuntu.com/release/

> 
>> 2. who will take responsibility for bumping the major/minor numbers? Is
>> that something you will do internally at Redhat?
> 
> I can take on the responsibility of bumping the major/minor numbers in the spec
> file.  I have no problem with that for the short term.
> 
> For the long road, I plan to modify buildrpm.sh to do
> 
> git-tag -l V${major}* | tail -1
> 
> which would return the latest V16 tag (currently V16.12.00).  I will use that
> value to modify fwts.spec.template, and create fwts.spec that would have major,
> minor, and subminor populated.  The only value I would have to store is the
> major number, 16.
> 
> ... but that's a later enhancement.  I'm just trying to get proof of concept and
> some initial testing in first :)
> 
OK, lets go with the script that you currently have, with the minor
updated to 12 and I'll then ACK the patches. We can work on getting more
smarts into the script at a later date. Do you mind sending a V3 and
I'll ack that.

Colin