ACK: [PATCH] dmicheck: update chassis type limit according to SMBIOS 3.0

Colin Ian King colin.king at canonical.com
Tue Feb 21 09:16:16 UTC 2017


On 21/02/17 08:44, Alex Hung wrote:
> In Table 17 - System Enclosure or Chassis Types, chassis
> type is up to 0x20.
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 196e139..d23c282 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1042,7 +1042,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			if (hdr->length < 0x09)
>  				break;
>  			dmi_str_check(fw, table, addr, "Manufacturer", hdr, 0x4);
> -			dmi_min_max_mask_uint8_check(fw, table, addr, "Chassis Type", hdr, 0x5, 0x1, 0x1d, 0x0, 0x7f);
> +			dmi_min_max_mask_uint8_check(fw, table, addr, "Chassis Type", hdr, 0x5, 0x1, 0x20, 0x0, 0x7f);
>  
>  			if (data[5] >=
>  				(sizeof(fwts_dmi_chassis_type) / sizeof(fwts_chassis_type_map))) {
> 

Thanks Alex,

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list