ACK: [PATCH] klog.json: Add some EFI driver kernel messages to klog database

[ivanhu]

On 2017年02月06日 22:17, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> These messages are specific to the EFI kernel driver.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  data/klog.json | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 91 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 0e3a3d1..d75d089 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2,6 +2,97 @@
>   "firmware_error_warning_patterns":
>   [
>    {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_LOW",
> +   "pattern": "need at least one option",
> +   "advice": "An incorrect (empty) argument was passed to the EFI driver via the efi= kernel option",
> +   "label": "KlogEfiEmptyArgument",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "pattern": "Unable to switch EFI into virtual mode",
> +   "advice": "The EFI driver was unable to swith the EFI runtime services to virtual mode, the call to the EFI service SetVirtualAddressMap failed and the kernel panic'd",
> +   "label": "KlogEfiSwitchToVirtualModePanic",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Failed to remap late EFI memory map",
> +   "advice": "The EFI driver could not remap the late EFI memory page, runtime service calls will be disabled",
> +   "label": "KlogEfiRemapLateMemoryMap",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Error reallocating memory, EFI runtime non-functional",
> +   "advice": "The EFI driver could not reallocate memory, runtime service calls will be disabled",
> +   "label": "KlogEfiReallocMemFailed",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Failed to remap late EFI memory map",
> +   "advice": "The EFI driver could not install a new EFI memory map, runtime service calls will be disabled",
> +   "label": "KlogEfiRemapEfiMemoryMapFailed",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Failed to allocate EFI page tables",
> +   "advice": "The EFI driver could not allocate EFI page tables when trying to enter EFI virtual mode, runtime service calls will be disabled",
> +   "label": "KlogEfiPageTablesAllocFailed",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "Could not map the firmware vendor",
> +   "advice": "The EFI firmware vendor information could not be memory mapped, vendor information will be incorrect.",
> +   "label": "KlogEfiMmapFirmwareVendorInfo",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Could not map the runtime service table",
> +   "advice": "The EFI runtime service table could not be mapped into memory, EFI has been disabled.",
> +   "label": "KlogEfiMmapRunTimeServiceTableFailed",
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_LOW",
> +   "pattern": "Warning: System table version .*, expected 1.00 or greater",
> +   "advice": "The EFI system table version was less than 1.00, which is not expected.  EFI support has been allowed, even if the version looks old and/or wrong",
> +   "label": "KlogEfiSystemTableVersionIssue",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "System table signature incorrect",
> +   "advice": "The EFI system table header signature did not match the expected signature, EFI table is not trustworthy and EFI has been disabled",
> +   "label": "KlogEfiBadSystemTableSignature",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "EFI data located above 4GB, disabling EFI",
> +   "advice": "The 32 bit system cannot memory map EFI data above the 32 bit address space limit of 4GB, EFI has been disabled",
> +   "label": "KlogEfiDataAbove4GB",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Couldn't map the system table",
> +   "advice": "The EFI system table could not be memory mapped, EFI support will be disabled",
> +   "label": "KlogEfiMmapSystemTableFailed",
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "Memory map is above 4GB, disabling EFI",
> +   "advice": "The 32 bit system cannot memory map EFI data above the 32 bit address space limit of 4GB, EFI has been disabled",
> +   "label": "KlogEfiMmapAbove4GB",
> +  },
> +  {
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_MEDIUM",
>     "pattern": "ACPI MWAIT C-state .* not supported by HW",
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>