ACK: [PATCH 2/2] fwts-tests: fix up spelling mistakes in regression tests

ivanhu ivan.hu at canonical.com
Tue Feb 7 02:54:58 UTC 2017



On 2017年01月31日 02:32, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The klog data was updated and so must the regression tests to
> be in sync with these changes.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  fwts-test/arg-log-format-0001/klog-0001.log |  2 +-
>  fwts-test/arg-log-format-0001/klog-0002.log |  2 +-
>  fwts-test/arg-log-format-0001/klog-0003.log |  5 +++--
>  fwts-test/arg-log-format-0001/klog-0004.log |  2 +-
>  fwts-test/klog-0001/klog-0001.log           | 28 ++++++++++++++--------------
>  5 files changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/fwts-test/arg-log-format-0001/klog-0001.log b/fwts-test/arg-log-format-0001/klog-0001.log
> index 87aba7b..e542bc8 100644
> --- a/fwts-test/arg-log-format-0001/klog-0001.log
> +++ b/fwts-test/arg-log-format-0001/klog-0001.log
> @@ -106,7 +106,7 @@ klog            (00127) <27/07/16> FAL H: 1, HIGH Kernel message: [ 0.000000]
>  klog            (00128) <27/07/16> FAL H: ACPI Warning: BIOS XSDT has NULL entry
>  klog            (00129) <27/07/16> FAL H: , using RSDT (20110112/tbutils-663)
>  klog            (00130) <27/07/16> NLN  :
> -klog            (00131) <27/07/16> ADV  : ADVICE: ACPI AML intepreter has found
> +klog            (00131) <27/07/16> ADV  : ADVICE: ACPI AML interpreter has found
>  klog            (00132) <27/07/16> ADV  : some non-conforming AML code. This
>  klog            (00133) <27/07/16> ADV  : should be investigated and fixed.
>  klog            (00134) <27/07/16> NLN  :
> diff --git a/fwts-test/arg-log-format-0001/klog-0002.log b/fwts-test/arg-log-format-0001/klog-0002.log
> index d4accd9..822dbe6 100644
> --- a/fwts-test/arg-log-format-0001/klog-0002.log
> +++ b/fwts-test/arg-log-format-0001/klog-0002.log
> @@ -69,7 +69,7 @@ klog           : FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel message:
>  klog           : [ 0.000000] ACPI Warning: BIOS XSDT has NULL entry, using RSDT
>  klog           : (20110112/tbutils-663)
>  klog           :
> -klog           : ADVICE: ACPI AML intepreter has found some non-conforming AML
> +klog           : ADVICE: ACPI AML interpreter has found some non-conforming AML
>  klog           : code. This should be investigated and fixed.
>  klog           :
>  klog           : FAILED [HIGH] KlogAcpiFadtInvalidLength: Test 1, HIGH Kernel
> diff --git a/fwts-test/arg-log-format-0001/klog-0003.log b/fwts-test/arg-log-format-0001/klog-0003.log
> index a98f22a..88a32de 100644
> --- a/fwts-test/arg-log-format-0001/klog-0003.log
> +++ b/fwts-test/arg-log-format-0001/klog-0003.log
> @@ -76,8 +76,9 @@ klog            00090: FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
>  klog            00091: message: [ 0.000000] ACPI Warning: BIOS XSDT has NULL
>  klog            00092: entry, using RSDT (20110112/tbutils-663)
>  klog            00093:
> -klog            00094: ADVICE: ACPI AML intepreter has found some non-conforming
> -klog            00095: AML code. This should be investigated and fixed.
> +klog            00094: ADVICE: ACPI AML interpreter has found some
> +klog            00095: non-conforming AML code. This should be investigated and
> +klog            00096: fixed.
>  klog            00096:
>  klog            00097: FAILED [HIGH] KlogAcpiFadtInvalidLength: Test 1, HIGH
>  klog            00098: Kernel message: [ 0.000000] ACPI Warning: Invalid length
> diff --git a/fwts-test/arg-log-format-0001/klog-0004.log b/fwts-test/arg-log-format-0001/klog-0004.log
> index 794501c..d6626ce 100644
> --- a/fwts-test/arg-log-format-0001/klog-0004.log
> +++ b/fwts-test/arg-log-format-0001/klog-0004.log
> @@ -80,7 +80,7 @@ klog            27/07/16 H: FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH
>  klog            27/07/16 H: Kernel message: [ 0.000000] ACPI Warning: BIOS XSDT
>  klog            27/07/16 H: has NULL entry, using RSDT (20110112/tbutils-663)
>  klog            27/07/16  :
> -klog            27/07/16  : ADVICE: ACPI AML intepreter has found some
> +klog            27/07/16  : ADVICE: ACPI AML interpreter has found some
>  klog            27/07/16  : non-conforming AML code. This should be investigated
>  klog            27/07/16  : and fixed.
>  klog            27/07/16  :
> diff --git a/fwts-test/klog-0001/klog-0001.log b/fwts-test/klog-0001/klog-0001.log
> index 033ae40..bc70890 100644
> --- a/fwts-test/klog-0001/klog-0001.log
> +++ b/fwts-test/klog-0001/klog-0001.log
> @@ -1943,7 +1943,7 @@ klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
>  klog            message: [ 0.000000] ACPI Warning: BIOS XSDT has NULL
>  klog            entry, using RSDT (20110112/tbutils-663)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [MEDIUM] KlogAcpiIncorrectTableChecksum: Test 1,
> @@ -5935,7 +5935,7 @@ klog            message: [ 0.310609] ACPI Warning for _PR_.CPU1._PSS:
>  klog            SubPackage[8,9] - suspicious power dissipation values
>  klog            (20100428/nsrepair2-403)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [MEDIUM] KlogAcpiIncorrectTableChecksum: Test 1,
> @@ -5970,7 +5970,7 @@ klog            message: [ 0.311335] ACPI Warning for _PR_.CPU2._PSS:
>  klog            SubPackage[8,9] - suspicious power dissipation values
>  klog            (20100428/nsrepair2-403)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiEventEnableFailed: Test 1, HIGH
> @@ -7987,7 +7987,7 @@ klog            message: [ 0.429245] ACPI Warning for _PR_.CPU0._TSD:
>  klog            Incorrectly formed Package, attempting repair (20090903
>  klog            /nsrepair-200)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
> @@ -7995,7 +7995,7 @@ klog            message: [ 0.430887] ACPI Warning for _PR_.CPU1._TSD:
>  klog            Incorrectly formed Package, attempting repair (20090903
>  klog            /nsrepair-200)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [MEDIUM] KlogAcpiIncorrectTableChecksum: Test 1,
> @@ -10310,7 +10310,7 @@ klog            message: [ 1.020868] ACPI Warning for _PR_.CPU0._PSD:
>  klog            Incorrectly formed Package, attempting repair (20090903
>  klog            /nsrepair-200)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
> @@ -10318,7 +10318,7 @@ klog            message: [ 1.021557] ACPI Warning for _PR_.CPU1._PSD:
>  klog            Incorrectly formed Package, attempting repair (20090903
>  klog            /nsrepair-200)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [MEDIUM] KlogAcpiIncorrectTableChecksum: Test 1,
> @@ -10635,7 +10635,7 @@ klog            message: [ 1.230869] ACPI Warning for _PR_.CPU0._PSS:
>  klog            SubPackage[15,16] - suspicious power dissipation values
>  klog            (20100428/nsrepair2-403)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
> @@ -10643,7 +10643,7 @@ klog            message: [ 1.231049] ACPI Warning for _PR_.CPU1._PSS:
>  klog            SubPackage[15,16] - suspicious power dissipation values
>  klog            (20100428/nsrepair2-403)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
> @@ -10651,7 +10651,7 @@ klog            message: [ 1.231224] ACPI Warning for _PR_.CPU2._PSS:
>  klog            SubPackage[15,16] - suspicious power dissipation values
>  klog            (20100428/nsrepair2-403)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
> @@ -10659,7 +10659,7 @@ klog            message: [ 1.231399] ACPI Warning for _PR_.CPU3._PSS:
>  klog            SubPackage[15,16] - suspicious power dissipation values
>  klog            (20100428/nsrepair2-403)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiNoHandlerForRegion: Test 1, HIGH
> @@ -11576,7 +11576,7 @@ klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
>  klog            message: [ 1.958776] ACPI Warning for _PR_.CPU0._PSD:
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiReturnPackageTypeMismatch: Test 1,
> @@ -15122,7 +15122,7 @@ klog            message: [ 50.737630] ACPI Warning for
>  klog            _SB_.PCI0.AGP_.VID_.MXMI: Excess arguments - needs 1,
>  klog            found 2 (20090903/nspredef-303)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            FAILED [HIGH] KlogAcpiBadAmlCode: Test 1, HIGH Kernel
> @@ -15130,7 +15130,7 @@ klog            message: [ 50.737686] ACPI Warning for
>  klog            _SB_.PCI0.AGP_.VID_.MXMS: Excess arguments - needs 1,
>  klog            found 2 (20090903/nspredef-303)
>  klog
> -klog            ADVICE: ACPI AML intepreter has found some non-conforming
> +klog            ADVICE: ACPI AML interpreter has found some non-conforming
>  klog            AML code. This should be investigated and fixed.
>  klog
>  klog            Found 1589 unique errors in kernel log.
>


Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list