[PATCH 1/2] data: fix some spelling mistakes in klog and olog databases
Jeremy Kerr
jk at ozlabs.org
Thu Feb 2 10:56:57 UTC 2017
Hi Colin,
>> The olog.json file is generated from the skiboot firmware source tree
>> though (which, of course, has the same spelling error):
>>
>> https://github.com/open-power/skiboot/blob/master/hw/slw.c#L1274
>
> Ah, I hadn't appreciated it's generated from this. That's good to know.
In case it's useful for other projects, we have a couple of tools to
generate (from the source tree) and merge (when updates occur) the olog
data:
https://github.com/open-power/skiboot/tree/master/external/fwts
>> To avoid losing this change next time we re-generate the olog.json data,
>> we'll fix this in the skiboot tree too.
>>
>> However, I'd like to ensure that future changes to the fwts tree don't
>> get out-of-sync with the sources used to generate the json. I have
>> couple of ideas for that:
>>
>> - we only manually update the skiboot tree, and get fixes to the json
>> as a result of re-generating the olog.json and sending diffs to fwts
>> (so instead of patching fwts, you can tell us we have a typo in
>> skiboot, and we'll handle the rest); or
>
> Let's go with the above and fix things at the original skiboot source.
OK, patch sent:
http://patchwork.ozlabs.org/patch/722967/
Since we've synchronised here, I'm happy for your patch to olog.json to
go in as-is. Or, if you prefer, we can send a separate update.
Consequently:
Acked-by: Jeremy Kerr <jk at ozlabs.org>
Thanks!
Jeremy
More information about the fwts-devel
mailing list