ACK: [PATCH 1/2] efi_runtime: fix the uninintialized value datasize
Alex Hung
alex.hung at canonical.com
Mon Sep 19 21:01:55 UTC 2016
On 2016-09-19 12:59 AM, Ivan Hu wrote:
> Fix the minor issue found by CoverityScan
> CID 1358931 (#1 of 1): Uninitialized scalar variable (UNINIT)9.
> uninit_use: Using uninitialized value datasize.
> 199 prev_datasize = datasize;
> 200 status = efi.get_variable(name, vd, at, dz, data);
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
> efi_runtime/efi_runtime.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/efi_runtime/efi_runtime.c b/efi_runtime/efi_runtime.c
> index 19f8103..34f452e 100644
> --- a/efi_runtime/efi_runtime.c
> +++ b/efi_runtime/efi_runtime.c
> @@ -174,7 +174,7 @@ static long efi_runtime_get_variable(unsigned long arg)
> {
> struct efi_getvariable __user *getvariable_user;
> struct efi_getvariable getvariable;
> - unsigned long datasize, prev_datasize, *dz;
> + unsigned long datasize = 0, prev_datasize, *dz;
> efi_guid_t vendor_guid, *vd = NULL;
> efi_status_t status;
> efi_char16_t *name = NULL;
>
Acked-by: Alex Hung <alex.hung at canonical.com>
More information about the fwts-devel
mailing list