ACK: [PATCH] devicetree: dt_sysinfo: Improve message for non-reference model

Alex Hung alex.hung at canonical.com
Fri Sep 2 00:44:06 UTC 2016


On 2016-09-02 02:40 AM, Deb McLemore wrote:
> Add informational output when no reference model is found to validate compatibility
>
> Signed-off-by: Deb McLemore <debmc at linux.vnet.ibm.com>
> ---
>  src/devicetree/dt_sysinfo/dt_sysinfo.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/devicetree/dt_sysinfo/dt_sysinfo.c b/src/devicetree/dt_sysinfo/dt_sysinfo.c
> index f9fc851..159dfc6 100644
> --- a/src/devicetree/dt_sysinfo/dt_sysinfo.c
> +++ b/src/devicetree/dt_sysinfo/dt_sysinfo.c
> @@ -187,8 +187,13 @@ static bool machine_matches_reference_model(fwts_framework *fw,
>  	}
>
>  	/* Not a reference platform, nothing to check */
> -	if (!compatible_is_reference)
> +	if (!compatible_is_reference) {
> +		fwts_log_info(fw, "Informational: no reference model found,"
> +			" device tree \"compatible\" is \"%s\" and"
> +			" \"model\" is \"%s\"",
> +			compatible, model);
>  		return true;
> +	}
>
>  	/* Since we're on a reference platform, ensure that the model is also
>  	 * one of the reference model numbers */
>


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list