ACK: [PATCH 3/6] acpi: pmtt: Show test as skipped if table does not exist

ivanhu ivan.hu at canonical.com
Mon Oct 17 08:07:46 UTC 2016



On 2016年10月15日 03:17, Jeffrey Hugo wrote:
> If the table does not exist, the error message states the test is being
> skipped, however the test is categorized as aborted.  The majority of other
> tests are categorized as skipped under this scenario.  Update the init path
> to return a SKIP error to categorize the test result similar to other tests.
>
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
>  src/acpi/pmtt/pmtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/pmtt/pmtt.c b/src/acpi/pmtt/pmtt.c
> index 18cb45c..7e5d763 100644
> --- a/src/acpi/pmtt/pmtt.c
> +++ b/src/acpi/pmtt/pmtt.c
> @@ -33,7 +33,7 @@ static int pmtt_init(fwts_framework *fw)
>  	}
>  	if (table == NULL) {
>  		fwts_log_error(fw, "ACPI PMTT table does not exist, skipping test");
> -		return FWTS_ERROR;
> +		return FWTS_SKIP;
>  	}
>
>  	return FWTS_OK;
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list