[PATCH] acpi: spcr: add missing debug port types (LP: #1578433)

Colin King colin.king at canonical.com
Thu May 5 08:40:21 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

The SPCR has debug port types as specified by the
Serial Port Subtypes in Table 3 of the DBG2 Specification
http://go.microsoft.com/fwlink/p/?LinkId=234837 - we are
missing types 0x0d..0x10, so add them.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/spcr/spcr.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/acpi/spcr/spcr.c b/src/acpi/spcr/spcr.c
index 970abf9..4b81b9a 100644
--- a/src/acpi/spcr/spcr.c
+++ b/src/acpi/spcr/spcr.c
@@ -59,7 +59,10 @@ static int spcr_test1(fwts_framework *fw)
 	bool pci = true;
 	bool passed = true;
 
-	/* Assuming revision 2 */
+	/*
+	 * Assuming revision 2, full list from
+	 * http://go.microsoft.com/fwlink/p/?LinkId=234837)
+	 */
 	switch (spcr->interface_type) {
 	case 0x00:
 		str = "16550 compatible";
@@ -75,6 +78,18 @@ static int spcr_test1(fwts_framework *fw)
 		str = "Reserved (Do not Use)";
 		reserved = true;
 		break;
+	case 0x0d:
+		str = "(deprecated) ARM SBSA";
+		break;
+	case 0x0e:
+		str = "ARM SBSA Generic UART";
+		break;
+	case 0x0f:
+		str = "ARM DCC";
+		break;
+	case 0x10:
+		str = "BCM2835";
+		break;
 	default:
 		str = "Reserved";
 		reserved = true;
-- 
2.7.4




More information about the fwts-devel mailing list