ACK: [PATCH 1/3] acpi: method: fix faile check on _EC control method (LP: #1556720)

[Alex Hung]

On 03/14/2016 03:18 PM, Ivan Hu wrote:
> Some firmware define H_EC object, this causes false alarm on fwts method tests.
> Test 169 of 195: Test _EC (EC Offset Query).
> FAILED [CRITICAL] AETtype: Test 169, Detected error 'Type' when evaluating
> '\_SB_.PCI0.SBRG.H_EC'.
>
>  From ACPI spec,
> ASL compiler pads a name shorter than 4 characters, it is done so with
> trailing underscores (‘_’).
> So fwts method should test with "_EC_".
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>   src/acpi/method/method.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index b8b5cf6..95efce3 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -91,7 +91,7 @@
>    * _DSW  7.2.1		Y
>    * _DTI  11.4.5		Y
>    * _Exx  5.6.4.1	n/a
> - * _EC   12.12		Y
> + * _EC_  12.12		Y
>    * _EDL  6.3.1		Y
>    * _EJD  6.3.2		Y
>    * _EJx  6.3.3		Y
> @@ -6324,10 +6324,10 @@ static int method_test_GPE(fwts_framework *fw)
>   		"_GPE", NULL, 0, method_test_GPE_return, "_GPE");
>   }
>
> -static int method_test_EC(fwts_framework *fw)
> +static int method_test_EC_(fwts_framework *fw)
>   {
>   	return method_evaluate_method(fw, METHOD_OPTIONAL,
> -		"_EC", NULL, 0, method_test_integer_return, NULL);
> +		"_EC_", NULL, 0, method_test_integer_return, NULL);
>   }
>
>   /*
> @@ -7147,7 +7147,7 @@ static fwts_framework_minor_test method_tests[] = {
>
>   	/* Section 12 Embedded Controller Interface */
>   	{ method_test_GPE, "Test _GPE (General Purpose Events)." },
> -	{ method_test_EC,  "Test _EC  (EC Offset Query)." },
> +	{ method_test_EC_,  "Test _EC_ (EC Offset Query)." },
>
>   	/* Section 16 Waking and Sleeping */
>
>


Acked-by: Alex Hung <alex.hung at canonical.com>