ACK: [PATCH] acpi: einj: erst: update serialization action for ACPI 6.1

ivanhu ivan.hu at canonical.com
Wed Jun 15 08:08:35 UTC 2016



On 2016年06月14日 17:13, Alex Hung wrote:
> ACPI 6.1 adds a new action GET_EXECUTE_OPERATION_TIMINGS for ERST (0x10)
> and for EINJ (0x09)
>
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>   src/acpi/einj/einj.c | 4 ++--
>   src/acpi/erst/erst.c | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/acpi/einj/einj.c b/src/acpi/einj/einj.c
> index 1b8b8db..4c8edef 100644
> --- a/src/acpi/einj/einj.c
> +++ b/src/acpi/einj/einj.c
> @@ -110,11 +110,11 @@ static int einj_test1(fwts_framework *fw)
>   		fwts_log_info_verbatim(fw, "    Mask                : 0x%16.16"
>   				PRIx64, entry->mask);
>
> -		if (entry->serialization_action > 0x8 &&
> +		if (entry->serialization_action > 0x9 &&
>   		    entry->serialization_action != 0xFF) {
>   			fwts_failed(fw, LOG_LEVEL_MEDIUM,
>   				    "EINJBadInjectionAction",
> -				    "EINJ Injection Action must be within 0~8 "
> +				    "EINJ Injection Action must be within 0~9 "
>   				    "or 0xFF got 0x%" PRIx8 " instead",
>   				    entry->serialization_action);
>   			passed = false;
> diff --git a/src/acpi/erst/erst.c b/src/acpi/erst/erst.c
> index b8c1ced..17ad13b 100644
> --- a/src/acpi/erst/erst.c
> +++ b/src/acpi/erst/erst.c
> @@ -113,7 +113,7 @@ static int erst_test1(fwts_framework *fw)
>   #endif
>
>   		switch (entry->serialization_action) {
> -		case 0x00 ... 0x0f:
> +		case 0x00 ... 0x10:
>   			/* Allow for reserved too */
>   			break;
>   		default:
> @@ -122,7 +122,7 @@ static int erst_test1(fwts_framework *fw)
>   				"ERSTIInvalidAction",
>   				"ERST Serialization Action 0x%" PRIx8
>   				" is an invalid value, values allowed are "
> -				"0x00..0x0f",
> +				"0x00..0x10",
>   				entry->serialization_action);
>   			break;
>   		}
>

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list