ACK: [PATCH] acpi: method: update _GCP test according to ACPI 6.1

Colin Ian King colin.king at canonical.com
Tue Jun 14 07:38:26 UTC 2016


On 14/06/16 10:35, Alex Hung wrote:
> ACPI 6.1 adds a new return value Bit [4]:
> 1 = _GWS returns correct values for wakes from S4/S5 caused by timer.
> 0 = not supported
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/acpi/method/method.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 38e9631..d219961 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -4656,11 +4656,11 @@ static void method_test_GCP_return(
>  	if (method_check_type(fw, name, buf, ACPI_TYPE_INTEGER) != FWTS_OK)
>  		return;
>  
> -	if (obj->Integer.Value & ~0xf)
> +	if (obj->Integer.Value & ~0x1f)
>  		fwts_failed(fw, LOG_LEVEL_MEDIUM,
>  			"Method_GCPReturn",
> -			"%s returned %" PRId64 ", should be between 0 and 15, "
> -			"one or more of the reserved bits 4..31 seem "
> +			"%s returned %" PRId64 ", should be between 0 and 31, "
> +			"one or more of the reserved bits 5..31 seem "
>  			"to be set.",
>  			name, (uint64_t)obj->Integer.Value);
>  	else
> 
Thanks Alex,

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list