[PATCH] Add klog checking for errors from drivers/acpi/tables.c

Colin King colin.king at canonical.com
Tue Jul 26 14:57:47 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

Add more klog error message checking for the ACPI driver

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 data/klog.json | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/data/klog.json b/data/klog.json
index d4735ed..917857c 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2,6 +2,62 @@
  "firmware_error_warning_patterns":
  [ 
   {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "\\[.*:.*\\] Invalid zero length",
+   "advice": "An ACPI MADT subtable has been found with an invalid zero length. MADT parsing was aborted.",
+   "label": "KlogAcpiMadtZeroLengthSubTable"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "pattern": "BIOS bug: multiple APIC/MADT found, using",
+   "advice": "The BIOS is supposed to supply just one APIC/MADT, however, more than one has been found. One can use acpi_apic_instance=N to specify the Nth ACPI/MADT to use as an override if required.",
+   "label": "KlogAcpiMultipleMadt"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_LOW",
+   "pattern": "Override \\[.*\\], this is unsafe: tainting kernel",
+   "advice": "One or more ACPI tables have been overridden with replacement tables, this sets a taint bit in the kernel since this is an unsafe operation.",
+   "label": "KlogAcpiKernelTainted"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "ACPI OVERRIDE: Table smaller than ACPI header",
+   "advice": "An override ACPI table from kernel/firmware/acpi has an invalid ACPI table header size and will be ignored.",
+   "label": "KlogAcpiInvalidOverrideTable"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "ACPI OVERRIDE: Unknown signature",
+   "advice": "An override ACPI table has an unknown ACPI table signature and will be ignored.",
+   "label": "KlogAcpiInvalidOverrideTableSig"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "ACPI OVERRIDE: File length does not match table length",
+   "advice": "An override ACPI table has an invalid length and will be ignored.",
+   "label": "KlogAcpiInvalidOverrideTableLength"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "ACPI OVERRIDE: Bad table checksum",
+   "advice": "An override ACPI table has an invalid checksum and will be ignored.",
+   "label": "KlogAcpiInvalidOverrideTableChecksum"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_LOW",
+   "pattern": "Shall use APIC/MADT table",
+   "advice": "The BIOS is supposed to supply just one APIC/MADT, however, more than one has been found.  Using a specific MADT table.",
+   "label": "KlogAcpiMadtSelected"
+  },
+  {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "pattern": "IRQ method execution failed",
-- 
2.8.1




More information about the fwts-devel mailing list