Some general development questions

Prarit Bhargava prarit at redhat.com
Tue Jul 26 12:50:28 UTC 2016


1.  It seems like the correct procedure on this list to review a patch is to

a) add ACK: to the subject, and
b) Add an Acked-by: line to the end of the patch.

Is one notification or the other also acceptable?

2.  Is the intent of fwts to test for *specific* known failure cases, or should
an overall general approach to verification be taken?  For example, I've seen a
failure in _DSM methods on specific vendor's hardware.  Should I target a test
for that failure, or make the test as broad as possible?

[This is a loaded question -- in some cases there is a lot of information in the
tables and it may be better to take a step approach to enhancing the test suite.]

3.  debian/ exists.  Is it okay to add a fedora directory that contains a
buildrpm.sh script & fwts.spec file?

4.  [This one is more of a personal statement and question :)]  I suck at
Makefiles.  I *really* *really* *really* suck at them.

I have noticed the following issue that I think should be addressed in the
Makefile.  When executing 'fwts --uefitests' the efi_runtime module is not
automatically loaded into the kernel.  I think that would be a trivial exercise
for someone more familiar with the Makefile layout than I am ;) -- who is the
right person to ping for that request?

4a)  Is there any reason that efi_runtime only exists in fwts and not the kernel
(linux.git) tree?

P.



More information about the fwts-devel mailing list