ACK: [PATCH] acpi: dbg2: Add missing debug port types

Alex Hung alex.hung at canonical.com
Mon Jul 25 01:39:20 UTC 2016


On 2016-07-23 12:14 AM, Jeffrey Hugo wrote:
> We are missing subtypes 0x0d..0x10 of type 0x8000 (Serial) from Table 3 of
> the DBG2 Specification http://go.microsoft.com/fwlink/p/?LinkId=234837 - so
> add them.
>
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
>  src/acpi/dbg2/dbg2.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index f8f3d09..72ceaab 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -230,6 +230,18 @@ static int dbg2_test1(fwts_framework *fw)
>  			case 0x0003:
>  				subport = "ARMPL011 UART";
>  				break;
> +			case 0x000d:
> +				subport = "ARM SBSA Generic UART (deprecated)";
> +				break;
> +			case 0x000e:
> +				subport = "ARM SBSA Generic UART";
> +				break;
> +			case 0x000f:
> +				subport = "ARM DCC";
> +				break;
> +			case 0x0010:
> +				subport = "BCM2835";
> +				break;
>  			default:
>  				break;
>  			}
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list