[PATCH] fwts/madt: Remove TODO for x2apic > 255 check
Al Stone
al.stone at linaro.org
Thu Jul 21 15:53:40 UTC 2016
On 07/21/2016 09:34 AM, Prarit Bhargava wrote:
> The x2apic ID can be a 32-bit value starting from 0. The TODO was likely
> introduced by this comment in section 5.2.12.12, of the ACPI6.0
> specification:
>
> "Note: [Compatibility note] On some legacy OSes, Logical processors with APIC
> ID values less than 255 (whether in XAPIC or X2 APIC mode) must use the
> Processor Local APIC structure to convey their APIC information to OSPM, and
> those processors must be declared in the DSDT using the Processor() keyword.
> Logical processors with APIC ID values 255 and greater must use the Processor
> Local x2APIC structure and be declared using the Device() keyword. See Section
> 19.6.102 "Processor (Declare Processor)" for more information."
>
> This does not mean that the lower bound of the x2apic ID is 255, rather
> that there are older OSes that will only interpret the lapic struct for
> x[2]apic IDs 0-255, and will interpret the x2apic struct for x2apic IDs
> greater than 255.
>
> Signed-off-by: Prarit Bhargava <prarit at redhat.com>
Either I write really good comments or Prarit can read minds :). I prefer
to think Prarit is telepathic.
Yup, that was exactly the intent of the TODO. Thanks for the clarification.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone at linaro.org
-----------------------------------
More information about the fwts-devel
mailing list