ACK: [PATCH] klog: data.json: Add klog checking for errors from drivers/acpi/battery.c

Alex Hung alex.hung at canonical.com
Wed Jul 13 02:59:43 UTC 2016


On 2016-07-12 04:31 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Add more klog error message checking for the ACPI battery driver.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   data/klog.json | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 710cea6..c15c4cb 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3,6 +3,13 @@
>    [
>     {
>      "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "pattern": "battery: (dis)charge rate invalid",
> +   "advice": "The ACPI Battery Status (_BST) object is returning an invalid dischar or charge rate.  This can be either a negative 16 bit value or reporing 0 as 65536 because of an invalid calculation in the DSDT. The Linux ACPI battery driver has detected this firmware bug and attempted to work around it.",
> +   "label": "KlogAcpiBstInvalidRate"
> +  },
> +  {
> +   "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "pattern": "Err sending PCC mbox message. cmd",
>      "advice": "The ACPI CPPC (Collaborative Processor Performance Control) driver attempted to send a command via the PCC mailbox but it failed to be sent. If this persists then the CPU freq drivers cannot control CPU performance using the _CPC ACPI tables.",
>


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list