[PATCH] opal/prd_info: Improve message when libfdt not installed

Deb McLemore debmc at linux.vnet.ibm.com
Tue Jul 12 19:53:37 UTC 2016


When running prd_info the device tree validation may
not succeed due to functional problems or lack of
proper setup and tools.  This patch will improve
the usability by suggesting methods to diagnose
the problem.

Signed-off-by: Deb McLemore <debmc at linux.vnet.ibm.com>
---
 src/opal/prd_info.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/opal/prd_info.c b/src/opal/prd_info.c
index 537d1ed..bdbfb9d 100644
--- a/src/opal/prd_info.c
+++ b/src/opal/prd_info.c
@@ -200,8 +200,15 @@ static int prd_info_init(fwts_framework *fw)
 		}
 #endif
 	} else {
-		fwts_log_info(fw, "The OPAL PRD device tree node"
-			" is not present so skipping test");
+		fwts_log_info(fw, "The OPAL PRD device tree node is not"
+			" able to be detected so skipping the prd_info"
+			" test.  There may be tools missing such as"
+			" libfdt-dev or dtc, check that the packages"
+			" are installed and re-build if needed."
+			" If this condition persists try running the"
+			" dt_base test to further diagnose. If dt_base"
+			" test is not available this is probably a"
+			" setup problem.");
 		return FWTS_SKIP;
 	}
 
-- 
1.8.3.1




More information about the fwts-devel mailing list