ACK: [PATCH] fwts-test: update fwts klog regression tests due to klog json changes

Alex Hung alex.hung at canonical.com
Mon Jul 11 02:57:32 UTC 2016


On 2016-07-08 01:38 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> The updated pci root _CRS check ("klog: data.json: Add klog checking
> for errors from drivers/acpi/pci_root.c") is a lower priority warning
> and we need to re-sync the fwts klog regression test to reflect this
> change
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   fwts-test/klog-0001/klog-0001.log | 15 ++++++++-------
>   fwts-test/klog-0001/klog-0002.log |  6 +++---
>   2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/fwts-test/klog-0001/klog-0001.log b/fwts-test/klog-0001/klog-0001.log
> index 34efc3d..7959b7a 100644
> --- a/fwts-test/klog-0001/klog-0001.log
> +++ b/fwts-test/klog-0001/klog-0001.log
> @@ -9094,13 +9094,14 @@ klog            ADVICE: This is a bug picked up by the kernel, but as yet,
>   klog            the firmware test suite has no diagnostic advice for this
>   klog            particular problem.
>   klog
> -klog            FAILED [MEDIUM] KlogAcpiCrsSecondaryBusRangeMissing: Test
> -klog            1, MEDIUM Kernel message: [ 0.663194] [Firmware Bug]: ACPI
> -klog            : no secondary bus range in _CRS
> -klog
> -klog            ADVICE: _CRS Method should return a secondary bus address
> -klog            for the status/command port. The kernel is having to guess
> -klog            this based on the _BBN or assume it's 0x00-0xff.
> +klog            FAILED [LOW] KlogAcpiPciCrsNoEndAddr: Test 1, LOW Kernel
> +klog            message: [ 0.663194] [Firmware Bug]: ACPI: no secondary
> +klog            bus range in _CRS
> +klog
> +klog            ADVICE: ACPI evaluated a _CRS (Current Resource Setting)
> +klog            object to determine the start and end of of a PCI
> +klog            downsteam bus range and did not find the end address, so
> +klog            an end address of 0xff is being assumed
>   klog
>   klog            FAILED [MEDIUM] KlogAcpiIncorrectTableChecksum: Test 1,
>   klog            MEDIUM Kernel message: [ 0.664875] ACPI Warning: Incorrect
> diff --git a/fwts-test/klog-0001/klog-0002.log b/fwts-test/klog-0001/klog-0002.log
> index a9ce1cc..d1d5023 100644
> --- a/fwts-test/klog-0001/klog-0002.log
> +++ b/fwts-test/klog-0001/klog-0002.log
> @@ -1253,7 +1253,7 @@ summary          klog: HIGH Kernel message: [ 44.661543] ACPI Warning for _SB_.P
>   summary          klog: HIGH Kernel message: [ 50.737630] ACPI Warning for _SB_.PCI0.AGP_.VID_.MXMI: Excess arguments - needs 1, found 2 (20090903/nspredef-303)
>   summary          klog: HIGH Kernel message: [ 50.737686] ACPI Warning for _SB_.PCI0.AGP_.VID_.MXMS: Excess arguments - needs 1, found 2 (20090903/nspredef-303)
>   summary
> -summary         Medium failures: 331
> +summary         Medium failures: 330
>   summary          klog: MEDIUM Kernel message: [ 0.000000] ACPI Warning: Incorrect checksum in table [APIC] - 0x3E, should be 0x41 (20110112/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 0.000000] ACPI Warning: Incorrect checksum in table [APIC] - 0x65, should be 0x68 (20110112/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 0.000000] ACPI Warning: Incorrect checksum in table [APIC] - 0x69, should be 0x6C (20110112/tbutils-314)
> @@ -1504,7 +1504,6 @@ summary          klog: MEDIUM Kernel message: [ 0.644838] [Firmware Bug]: PCI: M
>   summary          klog: MEDIUM Kernel message: [ 0.646493] ACPI Warning: Incorrect checksum in table [OEMB] - 0x5F, should be 0x5A (20100428/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 0.653985] ACPI Warning: Incorrect checksum in table [TAMG] - 0x4A, should be 0x49 (20110112/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 0.656750] ACPI Warning: Incorrect checksum in table [OEMB] - 06, should be 05 20090521 tbutils-246
> -summary          klog: MEDIUM Kernel message: [ 0.663194] [Firmware Bug]: ACPI: no secondary bus range in _CRS
>   summary          klog: MEDIUM Kernel message: [ 0.664875] ACPI Warning: Incorrect checksum in table [TAMG] - 0x45, should be 0x44 (20110112/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 0.666686] ACPI Warning: Incorrect checksum in table [TAMG] - 0x9E, should be 0x9D (20100428/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 0.670109] ACPI Warning: Incorrect checksum in table [OEMB] - 5B, should be 4E (20090903/tbutils-314)
> @@ -1586,8 +1585,9 @@ summary          klog: MEDIUM Kernel message: [ 3.382442] ACPI Warning: Incorrec
>   summary          klog: MEDIUM Kernel message: [ 3.644168] ACPI Warning: Incorrect checksum in table [TCPA] - 0xF8, should be 0x9C (20110413/tbutils-314)
>   summary          klog: MEDIUM Kernel message: [ 4.046031] ACPI Warning: Incorrect checksum in table [OEMB] - 4A, should be 47 (20090903/tbutils-314)
>   summary
> -summary         Low failures: 14
> +summary         Low failures: 15
>   summary          klog: LOW Kernel message: [ 0.094856] [Firmware Bug]: ACPI: No _BQC method, cannot determine initial brightness
> +summary          klog: LOW Kernel message: [ 0.663194] [Firmware Bug]: ACPI: no secondary bus range in _CRS
>   summary          klog: LOW Kernel message: [ 0.810246] [Firmware Bug]: ACPI(Z01I) defines _DOD but not _DOS
>   summary          klog: LOW Kernel message: [ 1.183989] [Firmware Bug]: ACPI(PEGD) defines _DOD but not _DOS
>   summary          klog: LOW Kernel message: [ 1.398000] [Firmware Bug]: ACPI(Z00P) defines _DOD but not _DOS
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list