ACK: [PATCH] dmi: dmicheck: fix reserved bits mask for Processor Information

[Alex Hung]

On 2016-01-07 01:00 AM, Fan Wu wrote:
> From: Fan Wu <wufan at codeaurora.org>
> Date: Tue, 5 Jan 2016 18:52:54 -0700
> Subject: [PATCH] dmi: dmicheck: fix reserved bits mask for Processor
>   Information
>
> This patch addresses following false alarm in FWTS dmicheck test:
>
> dmicheck: Reserved bits 0x009c was usedbits 8..15 would be reserved
> while accessing entry 'Processor Information (Type 4)' @ 0xf97f01d9,
> field 'Processor Characteristics', offset 0x26
>
> Signed-off-by: Fan Wu <wufan at codeaurora.org>
> ---
>   src/dmi/dmicheck/dmicheck.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index eeb227a..74805d2 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1171,7 +1171,7 @@ static void dmicheck_entry(fwts_framework *fw,
>   			dmi_str_check(fw, table, addr, "Part Number", hdr,
> 0x22);
>   			if (hdr->length < 0x28)
>   				break;
> -			if (GET_UINT16(data + 0x26) & 0xf0)
> +			if (GET_UINT16(data + 0x26) & 0xff00)
>   				fwts_failed(fw, LOG_LEVEL_MEDIUM,
> DMI_RESERVED_VALUE_USED,
>   					"Reserved bits 0x%4.4" PRIx16 " was
> used"
>   					"bits 8..15 would be reserved while
> accessing entry '%s' @ "
>


Acked-by: Alex Hung <alex.hung at canonical.com>