[PATCH] acpi: syntaxcheck: ASL_MSG_COMPILER_RESERVED failure should be an info (LP: #1529717)

Colin King colin.king at canonical.com
Fri Jan 1 00:53:37 UTC 2016


From: Colin Ian King <colin.king at canonical.com>

Reporting IASL remark #2011 as failure is quite confusing. If there are real
problems of using compiler reserved symbols, these problems should be caught
when comping ACPI source. It would be better to just log the remark as info.

[ Original patch from Fan Wu, commit message cleaned up for patch submission
  by Colin Ian King ]

Signed-off-by: Fan Wu <wufan at codeaurora.org>
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/syntaxcheck/syntaxcheck.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
index c5b0d27..449403b 100644
--- a/src/acpi/syntaxcheck/syntaxcheck.c
+++ b/src/acpi/syntaxcheck/syntaxcheck.c
@@ -547,7 +547,10 @@ static int syntaxcheck_table(
 							fwts_failed(fw, LOG_LEVEL_HIGH, label, "Assembler error in line %d", num);
 							break;
 						case ASL_REMARK:
-							fwts_failed(fw, LOG_LEVEL_LOW, label, "Assembler remark in line %d", num);
+							if (syntaxcheck_error_code_to_error_number(error_code) == ASL_MSG_COMPILER_RESERVED)
+								fwts_log_info(fw, "Assembler remark in line %d", num);
+							else
+								fwts_failed(fw, LOG_LEVEL_LOW, label, "Assembler remark in line %d", num);
 							break;
 						case ASL_OPTIMIZATION:
 							skip = true;
-- 
2.6.4




More information about the fwts-devel mailing list