[PATCH] acpica: s390x needs to be built as a 64 bit architecture

Al Stone al.stone at linaro.org
Mon Dec 12 17:24:00 UTC 2016


On 11/30/2016 06:07 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> We need to ensure 64 bit build for ACPICA on s390x.  I hope
> to get this fixed upstream in ACPICA soon. This fix cleans
> up build warnings on the ACPICA core on s390x
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpica/source/include/platform/aclinux.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h
> index 6f7c577..9d0927b 100644
> --- a/src/acpica/source/include/platform/aclinux.h
> +++ b/src/acpica/source/include/platform/aclinux.h
> @@ -265,7 +265,8 @@
>  #define ACPI_CAST_PTHREAD_T(Pthread) ((ACPI_THREAD_ID) (Pthread))
>  
>  #if defined(__ia64__)    || defined(__x86_64__) ||\
> -    defined(__aarch64__) || defined(__PPC64__)
> +    defined(__aarch64__) || defined(__PPC64__) ||\
> +    defined(__s390x__)
>  #define ACPI_MACHINE_WIDTH          64
>  #define COMPILER_DEPENDENT_INT64    long
>  #define COMPILER_DEPENDENT_UINT64   unsigned long
> 

Be careful with this: ACPICA is NOT big-endian safe; I've got patches in the
works for it to go into the acpica-tools packages, but I'm not quite finished
with them yet.  I thought I had them done Friday but ended up crashing acpiexec
with some test cases over the weekend.

Note, too, that the ASLTS suite sent with ACPICA does not catch this; it's
actually a false positive on big-endian machines.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone at linaro.org
-----------------------------------



More information about the fwts-devel mailing list