Bug about gRT->SetWakeupTime() testing in fwts-live-16.08.01

Tue Aug 30 09:29:09 UTC 2016

We met the issue when testing the SetWakeupTime() on "Enable is FALSE and Time is NULL", according to UEFI spec: If Enable is FALSE, then this parameter is optional, and may be NULL, that means "Enable is FALSE and Time is NULL" is a valid case and should not expect EFI_INVALID_PARAMETER return status.

Thanks,
Star
-----Original Message-----
From: ivanhu [mailto:ivan.hu at canonical.com] 
Sent: Tuesday, August 30, 2016 5:21 PM
To: Zeng, Star <star.zeng at intel.com>; fwts-devel at lists.ubuntu.com
Subject: Re: Bug about gRT->SetWakeupTime() testing in fwts-live-16.08.01

Hi Star,

This test will test the SetWakeupTime() on enable is true and Time is NULL, then expecting the EFI_INVALID_PARAMETER.

Check with the UEFI spec., unlike GetWakeupTime(), UFEI spec specified when time is NULL, need EFI_INVALID_PARAMETER return.

Status Codes Returned
EFI_INVALID_PARAMETER A time field is out of range.

for SetWakeupTime only specified EFI_INVALID_PARAMETER when time is out of range.

I'll sent out a patch to ignore this test.

Thanks for your information.

Cheers,

Ivan

On 2016年08月30日 17:02, Zeng, Star wrote:
> Hi Ivan,
>
> Only get the result for uefirttime: UEFI Runtime service time interface tests.
>
>
> uefirttime: UEFI Runtime service time interface tests.
> --------------------------------------------------------------------------------
> Test 1 of 35: Test UEFI RT service get time interface.
> PASSED: Test 1, UEFI runtime service GetTime interface test passed.
>
> Test 2 of 35: Test UEFI RT service get time interface, NULL time parameter.
> PASSED: Test 2, UEFI runtime service GetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 3 of 35: Test UEFI RT service get time interface, NULL time and NULL
> capabilties parameters.
> PASSED: Test 3, UEFI runtime service GetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 4 of 35: Test UEFI RT service set time interface.
> PASSED: Test 4, UEFI runtime service SetTime interface test passed.
>
> Test 5 of 35: Test UEFI RT service set time interface, invalid year 1899.
> PASSED: Test 5, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 6 of 35: Test UEFI RT service set time interface, invalid year 10000.
> PASSED: Test 6, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 7 of 35: Test UEFI RT service set time interface, invalid month 0.
> PASSED: Test 7, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 8 of 35: Test UEFI RT service set time interface, invalid month 13.
> PASSED: Test 8, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 9 of 35: Test UEFI RT service set time interface, invalid day 0.
> PASSED: Test 9, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 10 of 35: Test UEFI RT service set time interface, invalid day 32.
> PASSED: Test 10, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 11 of 35: Test UEFI RT service set time interface, invalid hour 24.
> PASSED: Test 11, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 12 of 35: Test UEFI RT service set time interface, invalid minute 60.
> PASSED: Test 12, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 13 of 35: Test UEFI RT service set time interface, invalid second 60.
> PASSED: Test 13, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 14 of 35: Test UEFI RT service set time interface, invalid nanosecond
> 1000000000.
> PASSED: Test 14, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 15 of 35: Test UEFI RT service set time interface, invalid timezone -1441.
> PASSED: Test 15, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 16 of 35: Test UEFI RT service set time interface, invalid timezone 1441.
> PASSED: Test 16, UEFI runtime service SetTime interface test passed, returned
> EFI_INVALID_PARAMETER as expected.
>
> Test 17 of 35: Test UEFI RT service get wakeup time interface.
> PASSED: Test 17, UEFI runtime service GetWakeupTime interface test passed.
>
> Test 18 of 35: Test UEFI RT service get wakeup time interface, NULL enabled
> parameter.
> PASSED: Test 18, UEFI runtime service GetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER or EFI_UNSUPPORTED as expected.
>
> Test 19 of 35: Test UEFI RT service get wakeup time interface, NULL pending
> parameter.
> PASSED: Test 19, UEFI runtime service GetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER or EFI_UNSUPPORTED as expected.
>
> Test 20 of 35: Test UEFI RT service get wakeup time interface, NULL time
> parameter.
> PASSED: Test 20, UEFI runtime service GetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER or EFI_UNSUPPORTED as expected.
>
> Test 21 of 35: Test UEFI RT service get wakeup time interface, NULL enabled,
> pending and time parameters.
> PASSED: Test 21, UEFI runtime service GetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER or EFI_UNSUPPORTED as expected.
>
> Test 22 of 35: Test UEFI RT service set wakeup time interface.
> PASSED: Test 22, UEFI runtime service SetWakeupTime interface test passed.
>
> Test 23 of 35: Test UEFI RT service set wakeup time interface, NULL time
> parameter.
> FAILED [HIGH] UEFIRuntimeSetWakeupTime: Test 23, Failed to get error return
> status from UEFI runtime service, expected EFI_INVALID_PARAMETER.
>
> Test 24 of 35: Test UEFI RT service set wakeup time interface, invalid year
> 1899.
> PASSED: Test 24, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 25 of 35: Test UEFI RT service set wakeup time interface, invalid year
> 10000.
> PASSED: Test 25, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 26 of 35: Test UEFI RT service set wakeup time interface, invalid month 0.
> PASSED: Test 26, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 27 of 35: Test UEFI RT service set wakeup time interface, invalid month 13.
> PASSED: Test 27, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 28 of 35: Test UEFI RT service set wakeup time interface, invalid day 0.
> PASSED: Test 28, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 29 of 35: Test UEFI RT service set wakeup time interface, invalid day 32.
> PASSED: Test 29, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 30 of 35: Test UEFI RT service set wakeup time interface, invalid hour 24.
> PASSED: Test 30, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 31 of 35: Test UEFI RT service set wakeup time interface, invalid minute
> 60.
> PASSED: Test 31, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 32 of 35: Test UEFI RT service set wakeup time interface, invalid second
> 60.
> PASSED: Test 32, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 33 of 35: Test UEFI RT service set wakeup time interface, invalid
> nanosecond 1000000000.
> PASSED: Test 33, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 34 of 35: Test UEFI RT service set wakeup time interface, invalid timezone
> -1441.
> PASSED: Test 34, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> Test 35 of 35: Test UEFI RT service set wakeup time interface, invalid timezone
> 1441.
> PASSED: Test 35, UEFI runtime service SetTimeWakeupTime interface test passed,
> returned EFI_INVALID_PARAMETER as expected.
>
> ================================================================================
> 34 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0 info only.
>
>
> Thanks,
> Star
> -----Original Message-----
> From: ivanhu [mailto:ivan.hu at canonical.com]
> Sent: Tuesday, August 30, 2016 4:55 PM
> To: Zeng, Star <star.zeng at intel.com>; fwts-devel at lists.ubuntu.com
> Subject: Re: Bug about gRT->SetWakeupTime() testing in fwts-live-16.08.01
>
> Hi Star,
>
> Thanks for you information.
>
> Can you attach the full result.log of this test?
>
>
> Cheers,
>
> Ivan
>
>
> On 2016年08月30日 16:02, Zeng, Star wrote:
>> Hi,
>>
>> Recently, our test team are using fwts-live-16.08.01 to test the UEFI firmware image, fwts-live-16.08.01 will report the error message below, but fwts-live-16.02.00 did not show.
>>
>> "Test 23 of 35: Test UEFI RT service set wakeup time interface, NULL time parameter.
>> Failed to get error return status from UEFI runtime service, expected EFI_INVALID_PARAMETER."
>>
>>
>> After checking the UEFI spec, the error message seems not reasonable according to the description of Time parameter.
>> Time
>> If Enable is TRUE, the time to set the wakeup alarm for. Type EFI_TIME is defined in the GetTime() function description. *If Enable is FALSE, then this parameter is optional, and may be NULL.*
>>
>>
>> Is it the bug about gRT->SetWakeupTime() testing in fwts-live-16.08.01?
>>
>>
>> Thanks,
>> Star
>>