ACK: [PATCH 2/3] acpi: wpbt: add ACPI WPBT test

[ivanhu]

On 2016年08月19日 12:26, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/Makefile.am      |   1 +
>  src/acpi/wpbt/wpbt.c | 110 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 111 insertions(+)
>  create mode 100644 src/acpi/wpbt/wpbt.c
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 15cc1a6..79071e9 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -101,6 +101,7 @@ fwts_SOURCES = main.c 				\
>  	acpi/wakealarm/wakealarm.c 		\
>  	acpi/wdat/wdat.c			\
>  	acpi/wmi/wmi.c 				\
> +	acpi/wpbt/wpbt.c			\
>  	acpi/xsdt/xsdt.c			\
>  	acpi/xenv/xenv.c			\
>  	apic/apicedge/apicedge.c 		\
> diff --git a/src/acpi/wpbt/wpbt.c b/src/acpi/wpbt/wpbt.c
> new file mode 100644
> index 0000000..c988d78
> --- /dev/null
> +++ b/src/acpi/wpbt/wpbt.c
> @@ -0,0 +1,110 @@
> +/*
> + * Copyright (C) 2016 Canonical
> + *
> + * Portions of this code original from the Linux-ready Firmware Developer Kit
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> + *
> + */
> +#include "fwts.h"
> +
> +#if defined(FWTS_HAS_ACPI)
> +
> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <unistd.h>
> +#include <inttypes.h>
> +#include <string.h>
> +#include <ctype.h>
> +
> +static fwts_acpi_table_info *table;
> +
> +static int wpbt_init(fwts_framework *fw)
> +{
> +	if (fwts_acpi_find_table(fw, "WPBT", 0, &table) != FWTS_OK) {
> +		fwts_log_error(fw, "Cannot read ACPI tables.");
> +		return FWTS_ERROR;
> +	}
> +	if (table == NULL || (table && table->length == 0)) {
> +		fwts_log_error(fw, "ACPI WPBT table does not exist, skipping test");
> +		return FWTS_SKIP;
> +	}
> +	return FWTS_OK;
> +}
> +
> +/*
> + *  WPBT Windows Platform Binary Table
> + */
> +static int wpbt_test1(fwts_framework *fw)
> +{
> +	fwts_acpi_table_wpbt *wpbt = (fwts_acpi_table_wpbt*) table->data;
> +	bool passed = true;
> +
> +	fwts_log_info_verbatim(fw, "WPBT Windows Platform Binary Table:");
> +	fwts_log_info_verbatim(fw, "  Handoff Memory Size:      0x%8.8" PRIx32, wpbt->handoff_size);
> +	fwts_log_info_verbatim(fw, "  Handoff Memory Location:  0x%16.16" PRIx64, wpbt->handoff_address);
> +	fwts_log_info_verbatim(fw, "  Content Layout:           0x%2.2" PRIx8, wpbt->layout);
> +	fwts_log_info_verbatim(fw, "  Content Type:             0x%2.2" PRIx8, wpbt->type);
> +
> +	if (wpbt->layout != 1) {
> +		passed = false;
> +		fwts_failed(fw, LOG_LEVEL_HIGH,
> +			"WPBTBadLayout",
> +			"WPBT supports Conent Layout 1 only, got "
> +			"0x%2.2" PRIx8 " instead", wpbt->layout);
> +	}
> +
> +	if (wpbt->type != 1) {
> +		passed = false;
> +		fwts_failed(fw, LOG_LEVEL_HIGH,
> +			"WPBTBadType",
> +			"WPBT supports Content Type 1 only, got "
> +			"0x%2.2" PRIx8 " instead", wpbt->type);
> +
> +	} else {
> +		fwts_acpi_table_wpbt_type1 *type = (fwts_acpi_table_wpbt_type1 *) (table->data + sizeof(fwts_acpi_table_wpbt));
> +		fwts_log_info_verbatim(fw, "  Arguments Length:         0x%4.4" PRIx16, type->arguments_length);
> +
> +		if (type->arguments_length % 2) {
> +			passed = false;
> +			fwts_failed(fw, LOG_LEVEL_HIGH,
> +				"WPBTBadArgumentLength",
> +				"WPBT arugments length must be multiple of 2, got "
> +				"0x%4.4" PRIx16 " instead", type->arguments_length);
> +		}
> +	}
> +
> +	fwts_log_nl(fw);
> +
> +	if (passed)
> +		fwts_passed(fw, "No issues found in WPBT table.");
> +
> +	return FWTS_OK;
> +}
> +
> +static fwts_framework_minor_test wpbt_tests[] = {
> +	{ wpbt_test1, "WPBT Windows Platform Binary Table test." },
> +	{ NULL, NULL }
> +};
> +
> +static fwts_framework_ops wpbt_ops = {
> +	.description = "WPBT Windows Platform Binary Table test.",
> +	.init        = wpbt_init,
> +	.minor_tests = wpbt_tests
> +};
> +
> +FWTS_REGISTER("wpbt", &wpbt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> +
> +#endif
>

All look good to me except "Portions of this code original from the 
Linux-ready Firmware Developer Kit"

Alex, maybe you can delete the line about "Linux-ready Firmware 
Developer Kit" when you commit the patch.

Acked-by: Ivan Hu <ivan.hu at canonical.com>