ACK: [PATCH] acpi: fadt: Remove HEADLESS check on reduced hardware
Colin Ian King
colin.king at canonical.com
Fri Aug 19 08:02:41 UTC 2016
On 18/08/16 18:16, Jeffrey Hugo wrote:
> The ACPI Spec technically states that the HEADLESS and reduced hardware
> flags are mututally exclusive, however the Spec provides no indication why
> a reduced hardware platform could not be HEADLESS. There currently are
> OSes such as VMware's ESXi which expect HEADLESS to be set where
> appropiate, regardless of the reduced hardware flag.
>
> Lets not penalize platforms for doing what is expected in the real world.
> We expect a future revision of the ACPI Spec to allow HEADLESS to be set
> with reduced hardware due to the existance of this real world usecase.
>
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
> src/acpi/fadt/fadt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c
> index 139c567..533882d 100644
> --- a/src/acpi/fadt/fadt.c
> +++ b/src/acpi/fadt/fadt.c
> @@ -687,7 +687,6 @@ static void acpi_table_check_fadt_reduced_hardware(fwts_framework *fw)
> FWTS_FACP_FLAG_P_LVL2_UP |
> FWTS_FACP_FLAG_RTC_S4 |
> FWTS_FACP_FLAG_TMR_VAL_EXT |
> - FWTS_FACP_FLAG_HEADLESS |
> FWTS_FACP_FLAG_CPU_SW_SLP |
> FWTS_FACP_FLAG_PCI_EXP_WAK |
> FWTS_FACP_FLAG_S4_RTC_STS_VALID |
>
This seems totally reasonable to me. Thanks Jeffrey.
Acked-by: Colin Ian King <colin.king at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20160819/651cec57/attachment.pgp>
More information about the fwts-devel
mailing list