ACK: [PATCH] lib: fwts_iasl: reduce scope of variable 'ret'

Alex Hung alex.hung at canonical.com
Wed Aug 17 09:59:37 UTC 2016


On 2016-08-17 05:55 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Minor change to fix cppcheck style warnings, no functional change
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_iasl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_iasl.c b/src/lib/src/fwts_iasl.c
> index 60811d8..ea1355c 100644
> --- a/src/lib/src/fwts_iasl.c
> +++ b/src/lib/src/fwts_iasl.c
> @@ -82,10 +82,9 @@ static int fwts_iasl_cache_tables_to_file(fwts_framework *fw)
>  	pid_t pid = getpid();
>  	char tmpname[PATH_MAX];
>  	fwts_acpi_table_info *table;
> -	int ret;
>
>  	for (cached_max = 0; cached_max < ACPI_MAX_TABLES; cached_max++) {
> -		ret = fwts_acpi_get_table(fw, cached_max, &table);
> +		int ret = fwts_acpi_get_table(fw, cached_max, &table);
>  		if (ret != FWTS_OK)
>  			return ret;
>  		if (table == NULL)
>

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list