ACK: [PATCH 2/3][V3] acpi: mpst: add ACPI MPST test
ivanhu
ivan.hu at canonical.com
Tue Aug 16 09:19:08 UTC 2016
On 2016年08月16日 13:50, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
> src/Makefile.am | 1 +
> src/acpi/mpst/mpst.c | 260 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 261 insertions(+)
> create mode 100644 src/acpi/mpst/mpst.c
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index bc23e8d..ff82cbc 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -70,6 +70,7 @@ fwts_SOURCES = main.c \
> acpi/madt/madt.c \
> acpi/mcfg/mcfg.c \
> acpi/mchi/mchi.c \
> + acpi/mpst/mpst.c \
> acpi/msct/msct.c \
> acpi/msdm/msdm.c \
> acpi/method/method.c \
> diff --git a/src/acpi/mpst/mpst.c b/src/acpi/mpst/mpst.c
> new file mode 100644
> index 0000000..7dc4cfa
> --- /dev/null
> +++ b/src/acpi/mpst/mpst.c
> @@ -0,0 +1,260 @@
> +/*
> + * Copyright (C) 2016 Canonical
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
> +#include "fwts.h"
> +
> +#if defined(FWTS_HAS_ACPI)
> +
> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <unistd.h>
> +#include <inttypes.h>
> +#include <stdbool.h>
> +
> +static fwts_acpi_table_info *table;
> +
> +static int mpst_init(fwts_framework *fw)
> +{
> + if (fwts_acpi_find_table(fw, "MPST", 0, &table) != FWTS_OK) {
> + fwts_log_error(fw, "Cannot load ACPI table");
> + return FWTS_ERROR;
> + }
> + if (table == NULL) {
> + fwts_log_error(fw, "ACPI MPST table does not exist, skipping test");
> + return FWTS_ERROR;
> + }
> +
> + return FWTS_OK;
> +}
> +
> +static int mpst_test1(fwts_framework *fw)
> +{
> + fwts_acpi_table_mpst *mpst = (fwts_acpi_table_mpst*) table->data;
> + fwts_acpi_table_mpst_power_node_list *node_list;
> + fwts_acpi_table_mpst_power_char_list *char_list;
> + bool passed = true;
> + uint32_t reserved;
> + uint32_t node_offset;
> + uint16_t i, j;
> +
> + reserved = (uint32_t) mpst->reserved[0] +
> + ((uint32_t) mpst->reserved[1] << 8) +
> + ((uint32_t) mpst->reserved[2] << 16);
> +
> + fwts_log_info_verbatim(fw, "MPST Table:");
> + fwts_log_info_verbatim(fw, " Communication Channel ID: 0x%2.2" PRIx8, mpst->channel_id);
> + fwts_log_info_verbatim(fw, " Reserved: 0x%8.8" PRIx32, reserved);
> +
> + if (reserved != 0) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_LOW,
> + "MPSTReservedNonZero",
> + "MPST reserved field must be zero, got "
> + "0x%8.8" PRIx32 " instead", reserved);
> + }
> +
> + node_list = (fwts_acpi_table_mpst_power_node_list *) (table->data + sizeof(fwts_acpi_table_mpst));
> + fwts_log_info_verbatim(fw, " Memory Power Node Count: 0x%4.4" PRIx16, node_list->count);
> + fwts_log_info_verbatim(fw, " Reserved: 0x%4.4" PRIx16, node_list->reserved);
> +
> + if (node_list->reserved != 0) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_LOW,
> + "MPSTReservedNonZero",
> + "MPST reserved field must be zero, got "
> + "0x%4.4" PRIx16 " instead", node_list->reserved);
> + }
> +
> + node_offset = sizeof(fwts_acpi_table_mpst) + (sizeof(fwts_acpi_table_mpst_power_node_list));
> + if (mpst->header.length < node_offset + sizeof(fwts_acpi_table_mpst_power_node) * node_list->count) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTOutOfBound",
> + "MPST's table length is too small to contain all sub-tables");
> + goto error;
> + }
> +
> + for (i = 0; i < node_list->count; i++) {
> + fwts_acpi_table_mpst_power_node *power_node = (fwts_acpi_table_mpst_power_node *) (table->data + node_offset);
> + uint32_t node_length;
> +
> + fwts_log_info_verbatim(fw, " MPST Power Node:");
> + fwts_log_info_verbatim(fw, " Flags: 0x%2.2" PRIx8, power_node->flags);
> + fwts_log_info_verbatim(fw, " Reserved: 0x%2.2" PRIx8, power_node->reserved);
> + fwts_log_info_verbatim(fw, " Memory Power Node Id: 0x%4.4" PRIx16, power_node->node_id);
> + fwts_log_info_verbatim(fw, " Power Node Length: 0x%8.8" PRIx32, power_node->length);
> + fwts_log_info_verbatim(fw, " Base Address: 0x%16.16" PRIx64, power_node->range_address);
> + fwts_log_info_verbatim(fw, " Memory Length: 0x%16.16" PRIx64, power_node->range_length);
> + fwts_log_info_verbatim(fw, " Number of Power States: 0x%8.8" PRIx32, power_node->num_states);
> + fwts_log_info_verbatim(fw, " Number of Physical Components: 0x%8.8" PRIx32, power_node->num_components);
> +
> + if (power_node->flags & ~0x7) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTBadPowerNodeFlags",
> + "MPST Power Node Flags Bit 3..7 be zero, got "
> + "0x%2.2" PRIx8 " instead", power_node->flags);
> + }
> +
> + if (power_node->reserved != 0) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_LOW,
> + "MPSTReservedNonZero",
> + "MPST reserved field must be zero, got "
> + "0x%2.2" PRIx8 " instead", power_node->reserved);
> + }
> +
> + node_length = sizeof(fwts_acpi_table_mpst_power_node) +
> + sizeof(fwts_acpi_table_mpst_power_state) * power_node->num_states +
> + sizeof(fwts_acpi_table_mpst_component) * power_node->num_components;
> +
> + if (power_node->length != node_length) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTBadPowerNodeLength",
> + "MPST Power Node Length should be 0x%8.8" PRIx32 ", got "
> + "0x%8.8" PRIx32 " instead", node_length, power_node->length);
> + }
> +
> + node_offset += sizeof(fwts_acpi_table_mpst_power_node);
> + if (mpst->header.length < node_offset + sizeof(fwts_acpi_table_mpst_power_state) * power_node->num_states) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTOutOfBound",
> + "MPST's table length is too small to contain all sub-tables");
> + goto error;
> + }
> +
> + for (j = 0; j < power_node->num_states; j++) {
> + fwts_acpi_table_mpst_power_state *state = (fwts_acpi_table_mpst_power_state *) (table->data + node_offset);
> + fwts_log_info_verbatim(fw, " Power State Value: 0x%2.2" PRIx8, state->value);
> + fwts_log_info_verbatim(fw, " Power State Information Index: 0x%2.2" PRIx8, state->info_index);
> + node_offset += sizeof(fwts_acpi_table_mpst_power_state);
> + }
> +
> + if (mpst->header.length < node_offset + sizeof(fwts_acpi_table_mpst_component) * power_node->num_components) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTOutOfBound",
> + "MPST's table length is too small to contain all sub-tables");
> + goto error;
> + }
> +
> + for (j = 0; j < power_node->num_components; j++) {
> + fwts_acpi_table_mpst_component *component = (fwts_acpi_table_mpst_component *) (table->data + node_offset);
> + fwts_log_info_verbatim(fw, " Physical Component Id: 0x%2.2" PRIx8, component->id);
> + node_offset += sizeof(fwts_acpi_table_mpst_component);
> + }
> + }
> +
> + char_list = (fwts_acpi_table_mpst_power_char_list *) (table->data + node_offset);
> + fwts_log_info_verbatim(fw, " Memory Characteristics Count: 0x%4.4" PRIx16, char_list->count);
> + fwts_log_info_verbatim(fw, " Reserved: 0x%4.4" PRIx16, char_list->reserved);
> +
> + if (char_list->reserved != 0) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_LOW,
> + "MPSTReservedNonZero",
> + "MPST reserved field must be zero, got "
> + "0x%4.4" PRIx16 " instead", char_list->reserved);
> + }
> +
> + node_offset += sizeof(fwts_acpi_table_mpst_power_char_list);
> + if (mpst->header.length < node_offset + sizeof(fwts_acpi_table_mpst_power_char) * char_list->count) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTOutOfBound",
> + "MPST's table length is too small to contain all sub-tables");
> + goto error;
> + }
> +
> + for (i = 0; i < char_list->count; i++) {
> + fwts_acpi_table_mpst_power_char *power_char = (fwts_acpi_table_mpst_power_char *) (table->data + node_offset);
> +
> + fwts_log_info_verbatim(fw, " MPST Power Characteristics:");
> + fwts_log_info_verbatim(fw, " Power State Structure ID: 0x%2.2" PRIx8, power_char->structure_id);
> + fwts_log_info_verbatim(fw, " Flags: 0x%2.2" PRIx8, power_char->flags);
> + fwts_log_info_verbatim(fw, " Reserved: 0x%4.4" PRIx16, power_char->reserved1);
> + fwts_log_info_verbatim(fw, " Average Power Consumed: 0x%8.8" PRIx32, power_char->average_power);
> + fwts_log_info_verbatim(fw, " Relative Power Saving: 0x%8.8" PRIx32, power_char->power_saving);
> + fwts_log_info_verbatim(fw, " Exit Latency: 0x%16.16" PRIx64, power_char->exit_latency);
> + fwts_log_info_verbatim(fw, " Reserved: 0x%16.16" PRIx64, power_char->reserved2);
> +
> + if ((power_char->structure_id & 0x3F) != 1) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTBadPowerCharacteristicsID",
> + "MPST Power Characteristics ID must be 1, got "
> + "0x%2.2" PRIx8 " instead", power_char->structure_id & 0x3F);
> + }
> +
> + if (((power_char->structure_id & 0xC0) >> 6) != 1) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTBadPowerCharacteristicsRevision",
> + "MPST Power Characteristics Revision must be 1, got "
> + "0x%2.2" PRIx8 " instead", (power_char->structure_id & 0xC0) >> 6);
> + }
> +
> + if (power_char->flags & ~0x7) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_HIGH,
> + "MPSTBadPowerCharacteristicsFlags",
> + "MPST Power Characteristics Flags Bit 3..7 be zero, got "
> + "0x%2.2" PRIx8 " instead", power_char->flags);
> + }
> +
> + if (power_char->reserved1 != 0) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_LOW,
> + "MPSTReservedNonZero",
> + "MPST reserved field must be zero, got "
> + "0x%4.4" PRIx16 " instead", power_char->reserved1);
> + }
> +
> + if (power_char->reserved2 != 0) {
> + passed = false;
> + fwts_failed(fw, LOG_LEVEL_LOW,
> + "MPSTReservedNonZero",
> + "MPST reserved field must be zero, got "
> + "0x%16.16" PRIx64 " instead", power_char->reserved2);
> + }
> +
> + node_offset += sizeof(fwts_acpi_table_mpst_power_char);
> + }
> +
> + fwts_log_nl(fw);
> +
> + if (passed)
> + fwts_passed(fw, "No issues found in MPST table.");
> +
> + error:
> + return FWTS_OK;
> +}
> +
> +static fwts_framework_minor_test mpst_tests[] = {
> + { mpst_test1, "Validate MPST table." },
> + { NULL, NULL }
> +};
> +
> +static fwts_framework_ops mpst_ops = {
> + .description = "MPST Memory Power State Table test.",
> + .init = mpst_init,
> + .minor_tests = mpst_tests
> +};
> +
> +FWTS_REGISTER("mpst", &mpst_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> +
> +#endif
Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20160816/1c52439f/attachment-0001.html>
More information about the fwts-devel
mailing list