ACK: [PATCH 0/6] pipeio: Add support for read-write pipes

Colin Ian King colin.king at canonical.com
Fri Apr 22 13:08:31 UTC 2016


On 22/04/16 06:41, Jeremy Kerr wrote:
> This change implements read-write pipe IO, to allow fwts to send data
> *to* a process, as well as the current functionality of reading from
> one.
> 
> We refactor the existing read-only pipes a little, mainly to return
> output data in output arguments, and use the return values as error
> status (this also fixes an existing issue for fwts_pipe_read when the
> child outputs no data). Then, we add functions to open, process and
> close these read-write pipes.
> 
> The existing read-only pipes then become a base-case of the read-write
> ones.
> 
> Regards,
> 
> 
> Jeremy
> 
> --
> 
> Jeremy Kerr (6):
>   pipeio: fix fwts_pipe_read return value when child produces no output
>   pipeio: Fix error handling in fwts_pipe_exec
>   pipeio: Rename fwts_pipe_open to fwts_pipe_open_ro, add fd as output
>     argument
>   pipeio: Add fwts_pipe_open_rw
>   pipeio: Add fwts_pipe_readwrite
>   pipeio: Add fwts_pipe_close2 to cleanup from fwts_open_pipe_rw.
> 
>  src/lib/include/fwts_pipeio.h |  10 +-
>  src/lib/src/fwts_cpu.c        |   2 +-
>  src/lib/src/fwts_devicetree.c |  10 +-
>  src/lib/src/fwts_dump.c       |   4 +-
>  src/lib/src/fwts_pipeio.c     | 219 +++++++++++++++++++++++++++++++++---------
>  5 files changed, 188 insertions(+), 57 deletions(-)
> 

Acking all 6 patches. Thanks Jeremy, this makes the interface(s) far
more flexible.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list