ACK: [PATCH 2/3] uefibootpath: add test for the SD device path

[Colin Ian King]

On 20/11/15 08:40, Ivan Hu wrote:
> Sync up with uefi spec. 2.5 for new messaging device path, SD device path.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/uefi/uefibootpath/uefibootpath.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/uefi/uefibootpath/uefibootpath.c b/src/uefi/uefibootpath/uefibootpath.c
> index fc75594..af2dbc1 100644
> --- a/src/uefi/uefibootpath/uefibootpath.c
> +++ b/src/uefi/uefibootpath/uefibootpath.c
> @@ -584,6 +584,16 @@ static int uefibootpath_check_dev_path(fwts_framework *fw, fwts_uefi_dev_path *d
>  				errors++;
>  			}
>  			break;
> +		case FWTS_UEFI_SD_DEVICE_PATH_SUBTYPE:
> +			if (len != sizeof(fwts_uefi_sd_dev_path)) {
> +				fwts_failed(fw, LOG_LEVEL_MEDIUM, "UEFISDDevPathLength",
> +					"The length of SD device path is %" PRIu16 " bytes "
> +					"and differs from UEFI specification defined %" PRIu16 " bytes.",
> +					len,
> +					(uint16_t)sizeof(fwts_uefi_sd_dev_path));
> +				errors++;
> +			}
> +			break;
>  		default:
>  			fwts_log_info_verbatum(fw, "Unknown subtype of Messaging Device Path.");
>  			break;
> 
Acked-by: Colin Ian King <colin.king at canonical.com>