ACK: [PATCH 2/3] uefibootpath: add test for the URI device path

Colin Ian King colin.king at canonical.com
Tue Nov 10 15:14:44 UTC 2015


On 05/11/15 08:55, Ivan Hu wrote:
> Sync up with uefi spec. 2.5 for new messaging device path, URI device path.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/uefi/uefibootpath/uefibootpath.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/uefi/uefibootpath/uefibootpath.c b/src/uefi/uefibootpath/uefibootpath.c
> index 51a38cc..3232bd1 100644
> --- a/src/uefi/uefibootpath/uefibootpath.c
> +++ b/src/uefi/uefibootpath/uefibootpath.c
> @@ -553,6 +553,16 @@ static int uefibootpath_check_dev_path(fwts_framework *fw, fwts_uefi_dev_path *d
>  				errors++;
>  			}
>  			break;
> +		case FWTS_UEFI_URI_DEVICE_PATH_SUBTYPE:
> +			if (len <= sizeof(fwts_uefi_uri_dev_path)) {
> +				fwts_failed(fw, LOG_LEVEL_MEDIUM, "UEFIURIDevPathLength",
> +					"The length of URI Device Path is %" PRIu16 " bytes "
> +					"should be larger than UEFI specification defined %" PRIu16 " bytes.",
> +					len,
> +					(uint16_t)sizeof(fwts_uefi_uri_dev_path));
> +				errors++;
> +			}
> +			break;
>  		default:
>  			fwts_log_info_verbatum(fw, "Unknow subtype of Messaging Device PaERRORth.");
>  			break;
> 
Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list