ACK: [PATCH 2/3] uefidump: add dumping the BMC device path

[Alex Hung]

On 11/05/2015 04:46 PM, Ivan Hu wrote:
> Add dumping with uefi spec. 2.5 for new hardware device path, BMC device path.
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/uefi/uefidump/uefidump.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 014abe2..83660a2 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -148,6 +148,13 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path, c
>  					c->controller);
>  			}
>  			break;
> +		case FWTS_UEFI_BMC_DEV_PATH_SUBTYPE:
> +			if (dev_path_len >= sizeof(fwts_uefi_bmc_dev_path)) {
> +				fwts_uefi_bmc_dev_path *b = (fwts_uefi_bmc_dev_path *)dev_path;
> +				path = uefidump_vprintf(path, "\\BMC(0x%" PRIx8 ",0x%" PRIx64 ")",
> +					b->interface_type, b->base_addr);
> +			}
> +			break;
>  		default:
>  			path = uefidump_vprintf(path, "\\Unknown-HW-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
>  			break;
> 


Acked-by: Alex Hung <alex.hung at canonical.com>