[PATCH 3/3] live-image/fwts-frontend-text: add a selection of acpi and uefi tests

Alex Hung alex.hung at canonical.com
Thu May 28 07:00:54 UTC 2015


That's a good idea. I will send out V2 shortly.

On Wed, May 27, 2015 at 6:10 PM, Colin Ian King
<colin.king at canonical.com> wrote:
> On 27/05/15 10:46, Alex Hung wrote:
>> This is to avoid to generate too much noise when members of UEFI
>> forum are only interested in ACPI and UEFI but not other tests.
>>
>> Signed-off-by: Alex Hung <alex.hung at canonical.com>
>> ---
>>  live-image/fwts-frontend-text | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/live-image/fwts-frontend-text b/live-image/fwts-frontend-text
>> index 0b506ab..3796043 100755
>> --- a/live-image/fwts-frontend-text
>> +++ b/live-image/fwts-frontend-text
>> @@ -235,10 +235,11 @@ do
>>       dialog --help-button --backtitle "$FWTS" --title "Select Tests" --radiolist \
>>               "This will run a suite of firmware tests that will check the BIOS and ACPI tables. It can also find issues that can cause Linux problems.\n\n\
>>  The default below is to run just all the Batch Tests, but you can select more tests below if required.\n\nPlease select below (using cursor up/down and space) and press enter to continue:" \
>> -             18 70 4 \
>> +             19 70 5 \
>>               1 "All Batch Tests" on \
>> -             2 "Select Individual Tests" off \
>> -             3 "Abort Testing" off \
>> +             2 "ACPI and UEFI Tests" off \
>
> Do we want instead:
>                 2 "ACPI tests" off \
>                 3 "UEFI tests" off \
>
> so users can chose one or both of these rather than "ACPI and UEFI".
>
>> +             3 "Select Individual Tests" off \
>> +             4 "Abort Testing" off \
>>       2> $OPTIONS
>>
>>       case $? in
>> @@ -250,9 +251,13 @@ The default below is to run just all the Batch Tests, but you can select more te
>>                       done_tests_finish
>>                       ;;
>>               '2')
>> -                     select_tests
>> +                     do_test "--acpi --uefi" 'Running ACPI and UEFI Tests'
>> +                     done_tests_finish
>>                       ;;
>>               '3')
>> +                     select_tests
>> +                     ;;
>> +             '4')
>>                       no_tests_finish
>>                       ;;
>>               esac
>>
>
>
> --
> fwts-devel mailing list
> fwts-devel at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel



-- 
Cheers,
Alex Hung



More information about the fwts-devel mailing list