ACK: [PATCH 14/30] acpi: allow various ACPI table tests to run without root access

Alex Hung alex.hung at canonical.com
Tue Jun 23 05:54:25 UTC 2015 

On 06/18/2015 04:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> ACPI tables can be accessed without the need of the FWTS_FLAG_ROOT_PRIV
> flag because the tables can be loaded from a file.  The root access check
> is performed at table load time, so if the user is loading them from
> the firmware or via /sys/firmware/acpi/tables then the fwts lib will
> do the checks and the tests will be skipped if there are insufficient
> access rights automatically.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/bert/bert.c | 2 +-
>  src/acpi/boot/boot.c | 2 +-
>  src/acpi/dbg2/dbg2.c | 2 +-
>  src/acpi/dbgp/dbgp.c | 2 +-
>  src/acpi/ecdt/ecdt.c | 2 +-
>  src/acpi/gtdt/gtdt.c | 2 +-
>  src/acpi/hest/hest.c | 2 +-
>  src/acpi/madt/madt.c | 2 +-
>  src/acpi/rsdp/rsdp.c | 2 +-
>  src/acpi/rsdt/rsdt.c | 2 +-
>  src/acpi/sbst/sbst.c | 2 +-
>  src/acpi/slit/slit.c | 2 +-
>  src/acpi/spcr/spcr.c | 2 +-
>  src/acpi/spmi/spmi.c | 2 +-
>  src/acpi/srat/srat.c | 2 +-
>  src/acpi/xsdt/xsdt.c | 2 +-
>  16 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/src/acpi/bert/bert.c b/src/acpi/bert/bert.c
> index cede990..5f2d7ca 100644
> --- a/src/acpi/bert/bert.c
> +++ b/src/acpi/bert/bert.c
> @@ -185,4 +185,4 @@ static fwts_framework_ops bert_ops = {
>  	.minor_tests = bert_tests
>  };
>  
> -FWTS_REGISTER("bert", &bert_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("bert", &bert_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/boot/boot.c b/src/acpi/boot/boot.c
> index 0c2e10b..ddd81f5 100644
> --- a/src/acpi/boot/boot.c
> +++ b/src/acpi/boot/boot.c
> @@ -108,4 +108,4 @@ static fwts_framework_ops boot_ops = {
>  	.minor_tests = boot_tests
>  };
>  
> -FWTS_REGISTER("boot", &boot_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("boot", &boot_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/dbg2/dbg2.c b/src/acpi/dbg2/dbg2.c
> index 065682a..f5b28c1 100644
> --- a/src/acpi/dbg2/dbg2.c
> +++ b/src/acpi/dbg2/dbg2.c
> @@ -406,4 +406,4 @@ static fwts_framework_ops dbg2_ops = {
>  	.minor_tests = dbg2_tests
>  };
>  
> -FWTS_REGISTER("dbg2", &dbg2_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("dbg2", &dbg2_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/dbgp/dbgp.c b/src/acpi/dbgp/dbgp.c
> index be6b132..46c4f36 100644
> --- a/src/acpi/dbgp/dbgp.c
> +++ b/src/acpi/dbgp/dbgp.c
> @@ -137,4 +137,4 @@ static fwts_framework_ops dbgp_ops = {
>  	.minor_tests = dbgp_tests
>  };
>  
> -FWTS_REGISTER("dbgp", &dbgp_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("dbgp", &dbgp_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/ecdt/ecdt.c b/src/acpi/ecdt/ecdt.c
> index 356b516..67c6ce7 100644
> --- a/src/acpi/ecdt/ecdt.c
> +++ b/src/acpi/ecdt/ecdt.c
> @@ -213,4 +213,4 @@ static fwts_framework_ops ecdt_ops = {
>  	.minor_tests = ecdt_tests
>  };
>  
> -FWTS_REGISTER("ecdt", &ecdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("ecdt", &ecdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/gtdt/gtdt.c b/src/acpi/gtdt/gtdt.c
> index 07aaaea..f4f20c5 100644
> --- a/src/acpi/gtdt/gtdt.c
> +++ b/src/acpi/gtdt/gtdt.c
> @@ -245,4 +245,4 @@ static fwts_framework_ops gtdt_ops = {
>  	.minor_tests = gtdt_tests
>  };
>  
> -FWTS_REGISTER("gtdt", &gtdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("gtdt", &gtdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
> index f1724e5..a4e1f6c 100644
> --- a/src/acpi/hest/hest.c
> +++ b/src/acpi/hest/hest.c
> @@ -782,4 +782,4 @@ static fwts_framework_ops hest_ops = {
>  	.minor_tests = hest_tests
>  };
>  
> -FWTS_REGISTER("hest", &hest_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("hest", &hest_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/madt/madt.c b/src/acpi/madt/madt.c
> index c9a83fa..d32581d 100644
> --- a/src/acpi/madt/madt.c
> +++ b/src/acpi/madt/madt.c
> @@ -335,4 +335,4 @@ static fwts_framework_ops madt_ops = {
>  	.minor_tests = madt_tests
>  };
>  
> -FWTS_REGISTER("madt", &madt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("madt", &madt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/rsdp/rsdp.c b/src/acpi/rsdp/rsdp.c
> index cab263c..2fe530b 100644
> --- a/src/acpi/rsdp/rsdp.c
> +++ b/src/acpi/rsdp/rsdp.c
> @@ -93,4 +93,4 @@ static fwts_framework_ops rsdp_ops = {
>  	.minor_tests = rsdp_tests
>  };
>  
> -FWTS_REGISTER("rsdp", &rsdp_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("rsdp", &rsdp_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/rsdt/rsdt.c b/src/acpi/rsdt/rsdt.c
> index 0151b02..bfa2669 100644
> --- a/src/acpi/rsdt/rsdt.c
> +++ b/src/acpi/rsdt/rsdt.c
> @@ -82,4 +82,4 @@ static fwts_framework_ops rsdt_ops = {
>  	.minor_tests = rsdt_tests
>  };
>  
> -FWTS_REGISTER("rsdt", &rsdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("rsdt", &rsdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/sbst/sbst.c b/src/acpi/sbst/sbst.c
> index f16817d..d33c008 100644
> --- a/src/acpi/sbst/sbst.c
> +++ b/src/acpi/sbst/sbst.c
> @@ -92,4 +92,4 @@ static fwts_framework_ops sbst_ops = {
>  	.minor_tests = sbst_tests
>  };
>  
> -FWTS_REGISTER("sbst", &sbst_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("sbst", &sbst_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/slit/slit.c b/src/acpi/slit/slit.c
> index ef28d2a..274b050 100644
> --- a/src/acpi/slit/slit.c
> +++ b/src/acpi/slit/slit.c
> @@ -187,4 +187,4 @@ static fwts_framework_ops slit_ops = {
>  	.minor_tests = slit_tests
>  };
>  
> -FWTS_REGISTER("slit", &slit_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("slit", &slit_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/spcr/spcr.c b/src/acpi/spcr/spcr.c
> index 8eedb16..63c3189 100644
> --- a/src/acpi/spcr/spcr.c
> +++ b/src/acpi/spcr/spcr.c
> @@ -288,4 +288,4 @@ static fwts_framework_ops spcr_ops = {
>  	.minor_tests = spcr_tests
>  };
>  
> -FWTS_REGISTER("spcr", &spcr_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("spcr", &spcr_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/spmi/spmi.c b/src/acpi/spmi/spmi.c
> index 6afc63e..9c8dff6 100644
> --- a/src/acpi/spmi/spmi.c
> +++ b/src/acpi/spmi/spmi.c
> @@ -250,4 +250,4 @@ static fwts_framework_ops spmi_ops = {
>  	.minor_tests = spmi_tests
>  };
>  
> -FWTS_REGISTER("spmi", &spmi_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("spmi", &spmi_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/srat/srat.c b/src/acpi/srat/srat.c
> index 18a11dd..2a681a2 100644
> --- a/src/acpi/srat/srat.c
> +++ b/src/acpi/srat/srat.c
> @@ -351,4 +351,4 @@ static fwts_framework_ops srat_ops = {
>  	.minor_tests = srat_tests
>  };
>  
> -FWTS_REGISTER("srat", &srat_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("srat", &srat_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> diff --git a/src/acpi/xsdt/xsdt.c b/src/acpi/xsdt/xsdt.c
> index 779038a..bbb0a2f 100644
> --- a/src/acpi/xsdt/xsdt.c
> +++ b/src/acpi/xsdt/xsdt.c
> @@ -82,4 +82,4 @@ static fwts_framework_ops xsdt_ops = {
>  	.minor_tests = xsdt_tests
>  };
>  
> -FWTS_REGISTER("xsdt", &xsdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_ACPI)
> +FWTS_REGISTER("xsdt", &xsdt_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
> 

Acked-by: Alex Hung <alex.hung at canonical.com>

More information about the fwts-devel mailing list