ACK: [PATCH 09/30] acpi: acpitables: remove no-op MCFG test

Alex Hung alex.hung at canonical.com
Tue Jun 23 05:43:46 UTC 2015


On 06/18/2015 04:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> The MCFG test in acpitables has been a stubbed no-op
> for a long time and should be purged.  It will be properly
> implemented at a later date.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/acpitables/acpitables.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index a66697b..bc68603 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -256,12 +256,6 @@ static void acpi_table_check_sbst(fwts_framework *fw, fwts_acpi_table_info *tabl
>  	}
>  }
>  
> -static void acpi_table_check_mcfg(fwts_framework *fw, fwts_acpi_table_info *table)
> -{
> -	FWTS_UNUSED(fw);
> -	FWTS_UNUSED(table);
> -}
> -
>  typedef void (*check_func)(fwts_framework *fw, fwts_acpi_table_info *table);
>  
>  typedef struct {
> @@ -271,7 +265,6 @@ typedef struct {
>  
>  static acpi_table_check_table check_table[] = {
>  	{ "FACP", acpi_table_check_fadt },
> -	{ "MCFG", acpi_table_check_mcfg },
>  	{ "SBST", acpi_table_check_sbst },
>  	{ NULL  , NULL },
>  } ;
> 

We have a mcfg test already, there is no need to implement another one:)

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list